Add version command#216
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Apr 18, 2025
Merged
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
size/M
spencerhance
force-pushed
the
add-version-cmd
branch
from
08349c1 to
8956d8b
Compare
spencerhance
force-pushed
the
add-version-cmd
branch
from
8956d8b to
9a7b6fd
Compare
Contributor
Author
|
/assign @mlavacca |
spencerhance
force-pushed
the
add-version-cmd
branch
from
9a7b6fd to
abcb4f8
Compare
Adds a `version` command that can be used to display the current binary version.
Example:
./ingress2gateway version
ingress2gateway version: v0.4.0
Built with Go version: go1.24.2
* This is implemented via a combination of ldflags (to propogate the git tag info) and debug.BuildInfo (to get the golang version).
* This does not modify the CurrentVersion var in the i2gw package, but plan is to migrate that in a follow-up.
spencerhance
force-pushed
the
add-version-cmd
branch
from
abcb4f8 to
fe75323
Compare
Member
|
This is great, thanks @spencerhance! /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
Adds a `version` command that can be used to display the current binary version.
Example:
./ingress2gateway version
ingress2gateway version: v0.4.0
Built with Go version: go1.24.2
* This is implemented via a combination of ldflags (to propogate the git tag info) and debug.BuildInfo (to get the golang version).
* This does not modify the CurrentVersion var in the i2gw package, but plan is to migrate that in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a
versioncommand that can be used to display the current binary version.This is useful for users to be able to tell what version they are running, especially if installing via a package manager like homebrew.
Example:
Which issue(s) this PR fixes:
Fixes #213
Does this PR introduce a user-facing change?: