Add support for named ports

[gavinkflam]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support converting ingress rules with named ports.

Which issue(s) this PR fixes:

Fixes #209

Does this PR introduce a user-facing change?:

The proposed change includes the following steps:

1. Read service definitions at the same time as we read ingresses. (resource readers)
2. Construct a mapping from port names to port numbers for each service.
3. Use this mapping to resolve port name references into port numbers.

Add support for named ports

[k8s-ci-robot]

Welcome @gavinkflam!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @gavinkflam. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zirain]

/ok-to-test

[LiorLieberman]

/cc

[LiorLieberman]

Thanks for picking this up @gavinkflam !

Mind updating the PR description with the logic you added?

Also, cross ref kubernetes-sigs/gateway-api#2420 for why named ports are not supported.

[gavinkflam]

Thanks @LiorLieberman! I've updated the description to include an explanation of the implementation.

So upstream chose not to support named ports consciously. If that’s the case, it becomes even more important for us to support automatic migration via ingress2gateway.

[LiorLieberman]

/lgtm
/approve

/hold in case @robscott have other opinions

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gavinkflam, LiorLieberman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [LiorLieberman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[robscott]

Thanks @gavinkflam!

/hold cancel