Add NGINX provider support by sarthyparty · Pull Request #224 · kubernetes-sigs/ingress2gateway

sarthyparty · 2025-07-07T17:39:27Z

What type of PR is this?

/kind feature
What this PR does / why we need it:
This PR adds support for NGINX provider.
Which issue(s) this PR fixes:

Fixes #223

Does this PR introduce a user-facing change?:

Adds support for the NGINX provider in ingress2gateway.

If this PR is too large, I'd be happy to break it into smaller chunks

linux-foundation-easycla · 2025-07-07T17:39:31Z

The committers listed above are authorized under a signed CLA.

✅ login: sarthyparty / name: Sarthak Agrawal (53369fd, 4135da0, 8ee1bc9, c182d46, 2c07ad0, 60ca018, e21150b, 97d059c, a16a130, 8fd2288, af8cdf3, e85c28c, 8caa385, b185c8c, 8aab983, f748201, 2c6286d, d81c739, 9f1a18a, 4aa087b, 4414604, 14fcd95, fd75a1b, 050e59f, 6b6901c, 58eeebf, 78bc48a, 4b10a0c, 4575897)

k8s-ci-robot · 2025-07-07T17:39:36Z

Welcome @sarthyparty!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-07-07T17:39:37Z

Hi @sarthyparty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sarthyparty · 2025-07-07T17:52:07Z

Hey, sorry for the extremely large PR, I did not realize it was this large. I'm going to remove virtual server conversion code and some annotations that are not fully done to make it smaller. Feel free to toss any suggestions to break it into smaller chunks

sarthyparty · 2025-07-07T20:32:04Z

If this PR is still too large, I'd be happy to break it into smaller chunks

sjberman

Haven't gone through unit tests yet, but did a first pass of the implementation.

robscott · 2025-07-08T05:18:41Z

This is great to see, thanks @sarthyparty! Ping me whenever this is ready for review.

/ok-to-test

sjberman

Approving from my point of view. I'll let others finish their reviews too in case there's anything else :) Nice work.

bjee19

lgtm, nice job

salonichf5

🚀

sjberman · 2025-08-27T14:34:22Z

@levikobi @Xunzhuo You two are listed as reviewers on this PR. Would you be able to take a look or recommend someone else who has write access that can? We're hoping to get this in ASAP due to time constraints on our own team.

LiorLieberman · 2025-08-27T14:40:19Z

Let me have a look today

…

On Wed, 27 Aug 2025 at 7:34 Saylor Berman ***@***.***> wrote: *sjberman* left a comment (kubernetes-sigs/ingress2gateway#224) <#224 (comment)> @levikobi <https://github.com/levikobi> @Xunzhuo <https://github.com/Xunzhuo> You two are listed as reviewers on this PR. Would you be able to take a look or recommend someone else who has write access that can? We're hoping to get this in ASAP due to time constraints on our own team. — Reply to this email directly, view it on GitHub <#224 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASLANQVQFZMXKONGOLARNJ33PW6YJAVCNFSM6AAAAACA64XPXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRYGQ3DAOBVG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

LiorLieberman · 2025-08-27T16:00:20Z

/assign

LiorLieberman

This is very well written, thanks for putting the time.

Left a few comments after my initial review (and yes, it is hard to review 58 files lol - but I dont think you need to split after all the time you've waited :) )

LiorLieberman · 2025-08-28T23:02:06Z

/lgtm
/approve

🎉

k8s-ci-robot · 2025-08-28T23:02:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiorLieberman, sarthyparty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [LiorLieberman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add NGINX provider with annotation support * add more test * fix tls for custom ports * update readme * go mod tidy * align table * remove kubernetes from name * link issue in annotations readme * move issue link * add notifications for grpcfilter conversion * update grpc services test * update error message to be clearer * fix comments on header and rewrite * rename test functions * switch t error instead of t fatal * clean tests * rework tests to use error instead of fatal * resolve comments * Update banner to 2025 * Update readme, remove managed by labels * set target ref for btp to be core * update toir and merge irs * move grpc and btp logic to common * fix verify * remove core group var * Update comment and separate btp name gen function * remove unecessary labels * move btp name gen function to nginx provider * fix gofumpt

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 7, 2025

k8s-ci-robot requested review from Xunzhuo and levikobi July 7, 2025 17:39

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 7, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2025

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 7, 2025

sarthyparty changed the title ~~Add NGINX provider with partial annotation support~~ Add NGINX provider Jul 7, 2025

sarthyparty changed the title ~~Add NGINX provider~~ Add NGINX provider support Jul 7, 2025

sarthyparty closed this Jul 7, 2025

sarthyparty reopened this Jul 7, 2025

sjberman reviewed Jul 7, 2025

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 8, 2025

sjberman reviewed Jul 8, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/path_rewrite.go Outdated

sjberman reviewed Jul 8, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/listen_ports.go Outdated

sjberman reviewed Jul 9, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/ssl_redirect.go Outdated

sarthyparty requested a review from sjberman July 9, 2025 17:06

salonichf5 reviewed Jul 9, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/backend_protocol.go Outdated

salonichf5 reviewed Jul 10, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/resource_reader.go Outdated

salonichf5 reviewed Jul 10, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/backend_protocol.go Outdated

salonichf5 reviewed Jul 10, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/nginx/annotations/backend_protocol.go Outdated

Sarthak Agrawal added 2 commits August 5, 2025 10:10

rework tests to use error instead of fatal

f748201

resolve comments

8aab983

sjberman approved these changes Aug 6, 2025

View reviewed changes

bjee19 approved these changes Aug 18, 2025

View reviewed changes

salonichf5 approved these changes Aug 19, 2025

View reviewed changes

k8s-ci-robot assigned LiorLieberman Aug 27, 2025

Update banner to 2025

d81c739

LiorLieberman reviewed Aug 27, 2025

View reviewed changes

Sarthak Agrawal added 5 commits August 27, 2025 12:37

Update readme, remove managed by labels

050e59f

set target ref for btp to be core

14fcd95

update toir and merge irs

9f1a18a

move grpc and btp logic to common

4aa087b

fix verify

2c6286d

sarthyparty requested a review from LiorLieberman August 28, 2025 19:01

LiorLieberman reviewed Aug 28, 2025

View reviewed changes

Sarthak Agrawal added 5 commits August 28, 2025 14:58

remove core group var

fd75a1b

Update comment and separate btp name gen function

58eeebf

remove unecessary labels

4575897

move btp name gen function to nginx provider

6b6901c

fix gofumpt

4b10a0c

sarthyparty requested a review from LiorLieberman August 28, 2025 22:59

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025

k8s-ci-robot merged commit 162d11c into kubernetes-sigs:main Aug 28, 2025
4 checks passed

Conversation

sarthyparty commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linux-foundation-easycla Bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 7, 2025

Uh oh!

k8s-ci-robot commented Jul 7, 2025

Uh oh!

sarthyparty commented Jul 7, 2025

Uh oh!

sarthyparty commented Jul 7, 2025

Uh oh!

sjberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robscott commented Jul 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjberman left a comment

Choose a reason for hiding this comment

Uh oh!

bjee19 left a comment

Choose a reason for hiding this comment

Uh oh!

salonichf5 left a comment

Choose a reason for hiding this comment

Uh oh!

sjberman commented Aug 27, 2025

Uh oh!

LiorLieberman commented Aug 27, 2025 via email

Uh oh!

LiorLieberman commented Aug 27, 2025

Uh oh!

LiorLieberman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiorLieberman commented Aug 28, 2025

Uh oh!

k8s-ci-robot commented Aug 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

sarthyparty commented Jul 7, 2025 •

edited

Loading

linux-foundation-easycla Bot commented Jul 7, 2025 •

edited

Loading