Skip to content

Do not print the table on stdout#233

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
rikatz:do-not-print-the-table
Aug 18, 2025
Merged

Do not print the table on stdout#233
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
rikatz:do-not-print-the-table

Conversation

@rikatz
Copy link
Copy Markdown
Member

@rikatz rikatz commented Aug 18, 2025

What type of PR is this?
/kind bug

What this PR does / why we need it:
Stop printing the info table as part of the manifest. When we print to stdout the manifest becomes invalid and doing things like "ingress2gateway | kubectl apply -f -" won't work

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Print notification table on stderr

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@adrianmoisey
Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@rikatz
Copy link
Copy Markdown
Member Author

rikatz commented Aug 18, 2025

/cc @robscott @LiorLieberman

@robscott
Copy link
Copy Markdown
Member

Thanks @rikatz!

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit 61c3363 into kubernetes-sigs:main Aug 18, 2025
4 of 5 checks passed
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants