Do not require a namespace when input-file is used#241
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Sep 2, 2025
Merged
Do not require a namespace when input-file is used#241k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
Member
Author
|
/assign @LiorLieberman |
sarthyparty
reviewed
Sep 2, 2025
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
* Do not require a namespace when input-file is used * Address comment on initializeNamespaceFilter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR changes the behavior of i2g when using an input-file. In this case, as we are not querying a live Kubernetes cluster it may be expected that the namespace selector is not used unless it is explicitly required.
This way, when using --input-file without a namespace, all the namespaces are selected
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: