implement header manipulation for nginxingress by eladmotola · Pull Request #283 · kubernetes-sigs/ingress2gateway

eladmotola · 2025-12-15T19:47:27Z

What type of PR is this?
/kind feature

What this PR does / why we need it:
adding support for header manipulation
Which issue(s) this PR fixes:
#271

Fixes #

Does this PR introduce a user-facing change?:

linux-foundation-easycla · 2025-12-15T19:47:35Z

The committers listed above are authorized under a signed CLA.

✅ login: eladmotola / name: eladmotola (0e266fb, 1ac3ca8, 4ab5f61, 6b089ba, f0caa45, 0e7ad52, 2177c00, 2679f65, 409a726, 925d85f)

k8s-ci-robot · 2025-12-15T19:47:37Z

Welcome @eladmotola!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-15T19:47:38Z

Hi @eladmotola. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Stevenjin8 · 2025-12-17T20:17:58Z

/ok-to-test

Stevenjin8

some small nits. Thanks!

Stevenjin8 · 2025-12-26T18:18:10Z

@eladmotola Thanks! This is in my TODO list

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

Stevenjin8 · 2025-12-30T20:19:57Z

/lgtm

Stevenjin8 · 2026-01-05T15:59:43Z

@eladmotola I just noticed that the copyright headers have the wrong year. Do you mind applying the suggested changes? After that I'll find some people to /approve.

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

eladmotola · 2026-01-06T21:22:10Z

@Stevenjin8 Oops my bad
done

Stevenjin8 · 2026-01-08T23:20:18Z

/lgtm

robscott · 2026-01-13T06:22:37Z

Thanks @eladmotola!

/approve

k8s-ci-robot · 2026-01-13T06:22:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eladmotola, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* implement header manipulation for nginxingress * pr comments * fmt * fmt * fmt * fmt * add TODOs * fix mege from master * fmt * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * continue instead of panic * Update pkg/i2gw/providers/ingressnginx/headers_test.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/annotations.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/utils.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> --------- Co-authored-by: Steven Jin <stevenjin8@gmail.com>

* implement header manipulation for nginxingress * pr comments * fmt * fmt * fmt * fmt * add TODOs * fix mege from master * fmt * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * continue instead of panic * Update pkg/i2gw/providers/ingressnginx/headers_test.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/annotations.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/utils.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> --------- Co-authored-by: Steven Jin <stevenjin8@gmail.com> Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>

* implement header manipulation for nginxingress * pr comments * fmt * fmt * fmt * fmt * add TODOs * fix mege from master * fmt * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * continue instead of panic * Update pkg/i2gw/providers/ingressnginx/headers_test.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/annotations.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/headers.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> * Update pkg/i2gw/providers/ingressnginx/utils.go Co-authored-by: Steven Jin <stevenjin8@gmail.com> --------- Co-authored-by: Steven Jin <stevenjin8@gmail.com>

implement header manipulation for nginxingress

e4bc299

k8s-ci-robot requested review from LiorLieberman and rikatz December 15, 2025 19:47

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 15, 2025

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 15, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2025

Stevenjin8 reviewed Dec 17, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go Outdated

Stevenjin8 reviewed Dec 17, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go

Stevenjin8 reviewed Dec 17, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go Outdated

Stevenjin8 reviewed Dec 17, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go

Stevenjin8 reviewed Dec 17, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go Outdated

Stevenjin8 requested changes Dec 17, 2025

View reviewed changes

pr comments

aa0232e

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2025

eladmotola added 4 commits December 19, 2025 11:34

fmt

e507ae5

fmt

7855e52

fmt

a981915

fmt

2607469

Stevenjin8 reviewed Dec 26, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go

Stevenjin8 reviewed Dec 26, 2025

View reviewed changes

Comment thread pkg/i2gw/providers/ingressnginx/headers.go Outdated

eladmotola and others added 2 commits December 29, 2025 11:35

Update pkg/i2gw/providers/ingressnginx/headers.go

6b089ba

Co-authored-by: Steven Jin <stevenjin8@gmail.com>

continue instead of panic

2177c00

k8s-ci-robot assigned Stevenjin8 Dec 30, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2025