Ingress NGINX - Support Redirect by jgreeer · Pull Request #299 · kubernetes-sigs/ingress2gateway

jgreeer · 2026-01-09T21:10:36Z

What type of PR is this?

Fixes #268

Does this PR introduce a user-facing change?:

Add support for `nginx.ingress.kubernetes.io/permanent-redirect` and `nginx.ingress.kubernetes.io/temporal-redirect` + warnings for `nginx.ingress.kubernetes.io/proxy-redirect-from` and `nginx.ingress.kubernetes.io/proxy-redirect-to`

k8s-ci-robot · 2026-01-09T21:10:47Z

Hi @jgreeer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jgreeer · 2026-01-15T19:34:22Z

nginx.ingress.kubernetes.io/from-to-www-redirect, nginx.ingress.kubernetes.io/permanent-redirect-code, and nginx.ingress.kubernetes.io/temporal-redirect-code require 307/308 status code support, so they cannot be implemented until v1.5 release.

Stevenjin8 · 2026-01-22T18:18:03Z

tbh gwapi 1.5 is just around the corner. I think we can merge this as is. WDYT @mikemorris

jgreeer · 2026-01-23T20:53:55Z

tbh gwapi 1.5 is just around the corner. I think we can merge this as is. WDYT @mikemorris

this doesn't have the 307/308 status codes, it emits warnings for them. so we can merge now and then make another PR later for the status code annotations.

Stevenjin8 · 2026-01-28T20:02:55Z

/ok-to-test

jgreeer · 2026-02-13T23:51:18Z

Changed approach to the following:

Iterate through all rules in the IR
Find a rule that has a source ingress with a redirect annotation
Add the redirect filter to that rule using values from URL.parse()
Remove backendRef from that rule (yaml isn't accepted if we don't do this)
Keep existing backendSource since it still contributed that rule

Also, always override the path with "/" if no path is provided in the redirect annotation. Gateway api will keep the path from the match in the redirect, ingress-nginx does not.

Stevenjin8 · 2026-02-17T15:55:15Z

+				continue
+			}
+
+			// Get ingress from the first backend source (all backends in a rule should come from the same ingress)


I don thtink this is true. What about canary

It's not, but when you combine canary and redirect the redirect takes priority and no canary happens. Are there other situations where we might need to check other backend sources?

I don't think so.

@jgreeer can you fix

Ah, I thought you were agreeing. So fix to account for when canary is enabled? What would that look like?

Oh I was thinking of using'getNonCanaryIngress'

Stevenjin8 · 2026-02-17T15:57:01Z

+				}
+
+				// Warn about unsupported custom status code annotation
+				if ingress.Annotations[TemporalRedirectCodeAnnotation] != "" {


If its the TemporalRedirectCodeAnnotation is 301, its ok though. Also isn't the default 308 anyways? so we need to make a warning anyways.

*what if the TemporalRedirectCodeAnnotation is already 301

Default codes are 301/302. I will add a check for if the redirect code annotation is already a default though

Stevenjin8

@jgreeer could you add an integration test now that we have them

…patibility with kubernetes-sigs#299

Stevenjin8 · 2026-02-19T20:09:53Z

/approve

Stevenjin8 · 2026-02-26T20:55:28Z

@kkk777-7 @spencerhance @bexxmodd could one of you take a look or lgtm this.

bexxmodd · 2026-02-26T21:47:03Z

+				// Check custom status code annotation
+				if codeStr := ingress.Annotations[TemporalRedirectCodeAnnotation]; codeStr != "" {
+					code, err := strconv.Atoi(codeStr)
+					if err != nil || code != 302 {


Isn't HTTPRequestedRedirectFilter supports 303, 307, and 308 now?

yeah it's about to release with v1.5, i'll go ahead and add it to this PR now

bexxmodd · 2026-02-27T00:28:41Z

/approve
/lgtm

k8s-ci-robot · 2026-02-27T00:28:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, jgreeer, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Stevenjin8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…patibility with kubernetes-sigs#299

* feat(ingressnginx): add support for force-ssl-redirect and from-to-www-redirect annotations * fix(ingressnginx): remove force-ssl-redirect support and document compatibility with #299 * fix(ingressnginx): correct from-to-www-redirect hostnames and gateway generation * test(e2e): add e2e integration test for from-to-www-redirect and conform to GatewayAPI 301 validation * style: fix gofmt error in e2e verifiers * fix(ingressnginx): Fix from-to-www-redirect sectionName API validation and Lexicographic precedence * Fix syntax and redeclaration errors in merge resolution * rebased

added temoporal and permanent redirect

363d20e

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2026

k8s-ci-robot requested a review from LiorLieberman January 9, 2026 21:10

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2026

k8s-ci-robot requested a review from Stevenjin8 January 9, 2026 21:10

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2026

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2026

jgreeer added 2 commits January 9, 2026 16:18

moved annotations to annotations.go

a969c7b

start of adding status codes

d67662b

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026

Merge branch 'main' into ingress-nginx/support-redirect

584206e

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2026

jgreeer added 2 commits January 14, 2026 17:13

add more redirect annotations to file

222d591

remove status codes and warn about those annotations

08cc6f6

jgreeer added 2 commits January 16, 2026 16:40

parse URL and set for redirect

6edbfa0

add warnings for proxy-redirect annotations

3e3c4d4

jgreeer marked this pull request as ready for review January 16, 2026 18:16

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2026

k8s-ci-robot requested a review from rikatz January 16, 2026 18:16

jgreeer temporarily deployed to release January 22, 2026 18:18 — with GitHub Actions Inactive

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026

Merge branch 'main' into ingress-nginx/support-redirect

01fb5bf

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026

fix imports

712e81c

jgreeer mentioned this pull request Jan 26, 2026

feat(ingressnginx): implement redirect annotation support #316

Closed

5 tasks

jgreeer added 6 commits February 12, 2026 19:06

fixed backendrefs for redirect rule

00711fa

modify existing rule instead of creating a new one

f385e0b

replace full path as default

3346624

fix tests

a431c4e

lint

23bf2c9

iterate on all rules

5e76879

Stevenjin8 reviewed Feb 17, 2026

View reviewed changes

jgreeer added 3 commits February 18, 2026 18:13

accept default codes in permanent-redirect-code annotation

3524eb4

Merge branch 'main' into ingress-nginx/support-redirect

993ca43

added intergation tests

77174ab

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 18, 2026

chakravardhan added a commit to chakravardhan/ingress2gateway that referenced this pull request Feb 19, 2026

fix(ingressnginx): remove force-ssl-redirect support and document com…

cb5cb52

…patibility with kubernetes-sigs#299

jgreeer temporarily deployed to release February 20, 2026 04:03 — with GitHub Actions Inactive

get non canary ingress

b55125f

bexxmodd reviewed Feb 26, 2026

View reviewed changes

jgreeer added 2 commits February 26, 2026 22:13

check if ingress is nil

1aad786

add other status codes

5353829

k8s-ci-robot assigned bexxmodd Feb 27, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2026

k8s-ci-robot merged commit 5b1691d into kubernetes-sigs:main Feb 27, 2026
5 checks passed

chakravardhan added a commit to chakravardhan/ingress2gateway that referenced this pull request Mar 31, 2026

fix(ingressnginx): remove force-ssl-redirect support and document com…

22cad35

…patibility with kubernetes-sigs#299

Conversation

jgreeer commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jan 9, 2026

Uh oh!

jgreeer commented Jan 15, 2026

Uh oh!

Stevenjin8 commented Jan 22, 2026

Uh oh!

jgreeer commented Jan 23, 2026

Uh oh!

Stevenjin8 commented Jan 28, 2026

Uh oh!

jgreeer commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgreeer Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Stevenjin8 left a comment

Choose a reason for hiding this comment

Uh oh!

Stevenjin8 commented Feb 19, 2026

Uh oh!

Stevenjin8 commented Feb 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bexxmodd commented Feb 27, 2026

Uh oh!

k8s-ci-robot commented Feb 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jgreeer commented Jan 9, 2026 •

edited

Loading

jgreeer commented Feb 13, 2026 •

edited

Loading

jgreeer Feb 18, 2026 •

edited

Loading