Skip to content

Don't error on nil ingress.rules.http#335

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Stevenjin8:fix/nil-http-panic
Feb 5, 2026
Merged

Don't error on nil ingress.rules.http#335
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Stevenjin8:fix/nil-http-panic

Conversation

@Stevenjin8
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #329

Does this PR introduce a user-facing change?:

Fix bug where empty Ingress resource caused a panic

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 5, 2026
@k8s-ci-robot k8s-ci-robot requested a review from kkk777-7 February 5, 2026 02:22
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkk777-7, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Feb 5, 2026

LGTM, thanks!

@Stevenjin8
Copy link
Copy Markdown
Contributor Author

@kkk777-7 can you give an /lgtm

@kkk777-7
Copy link
Copy Markdown
Member

kkk777-7 commented Feb 5, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2026
@k8s-ci-robot k8s-ci-robot merged commit 976ce6e into kubernetes-sigs:main Feb 5, 2026
5 checks passed
rajashish pushed a commit to rajashish/ingress2gateway1 that referenced this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingress2gateway crash on common.groupIngressPathsByMatchKey

3 participants