Resolve hosts outside verifiers#351
Merged
k8s-ci-robot merged 2 commits intokubernetes-sigs:mainfrom Feb 16, 2026
Merged
Conversation
It's hard to know which ingress is being verified in test cases with multiple ingresses. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
This makes the verifier logs more informative and less confusing. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
requested review from
LiorLieberman,
Stevenjin8,
robscott and
youngnick
as code owners
k8s-ci-robot
added
size/M
Contributor
|
/approve |
k8s-ci-robot
added
the
approved
Contributor
|
/approve cancel |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johananl, Stevenjin8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chakravardhan
pushed a commit
to chakravardhan/ingress2gateway
that referenced
this pull request
Feb 19, 2026
* Include ingress name in verifier logs It's hard to know which ingress is being verified in test cases with multiple ingresses. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Resolve hosts outside verifiers This makes the verifier logs more informative and less confusing. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> --------- Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
* Include ingress name in verifier logs It's hard to know which ingress is being verified in test cases with multiple ingresses. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Resolve hosts outside verifiers This makes the verifier logs more informative and less confusing. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> --------- Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the verifier logs by resolving hosts outside the verifiers and logging the host value instead of an ingress name.