Fix reading ingresses from cluster#357
Conversation
When no input files are specified in CLI args, fall back to reading ingresses from cluster rather than erroring out. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
johananl
requested review from
LiorLieberman,
Stevenjin8,
robscott and
youngnick
as code owners
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
/cc @carmal891 |
|
@johananl: GitHub didn't allow me to request PR reviews from the following users: carmal891. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johananl, Stevenjin8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
When no input files are specified in CLI args, fall back to reading ingresses from cluster rather than erroring out. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
When no input files are specified in CLI args, fall back to reading ingresses from cluster rather than erroring out. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
3 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a regression introduced in #258 where i2gw no longer reads ingresses from the cluster when no input files are specified.
Which issue(s) this PR fixes:
Fixes #356
Does this PR introduce a user-facing change?: