Refactor notification mechanism#360
Conversation
|
Skipping CI for Draft Pull Request. |
723f2c3 to
a1612a1
Compare
a1612a1 to
32beae2
Compare
32beae2 to
f5bbf4a
Compare
f5bbf4a to
f4a8e55
Compare
f4a8e55 to
ecd57d4
Compare
ecd57d4 to
105737b
Compare
105737b to
f9ecf5d
Compare
f9ecf5d to
8bcb4e4
Compare
8bcb4e4 to
a9206bf
Compare
a9206bf to
ea0be27
Compare
|
/test pull-ingress2gateway-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johananl, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We have no character limit on the notification message which can mess up the tables when the terminal isn't big enough. I'm fine with either format. The colored box design was done using an slog handler. I can look into "porting" the visuals without reintroducing the logging library (since we've agreed to keep notifications as distinct from logs). |
|
@johananl makes sense. |
|
I'm porting the design from #341. |
1112e49 to
0f82553
Compare
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
0f82553 to
5221299
Compare
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
We use the standard log package instead of klog in a few places. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
5221299 to
88955af
Compare
|
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR refactors the notification mechanism. Here is what it does specifically:
Reporttype.Reportinstance is created inToGatewayAPIResources().*Reportpointer is passed to each provider/emitter constructor.Report.Notifier()to create its own provider/emitter-scopedNotifyFuncand stores this function as a property.notify()function.There are no user-facing changes -- this is an implementation change only. The size of the PR is largely due to repetitive replacements of the "instrumentation" everywhere.
Which issue(s) this PR fixes:
Fixes #340
Does this PR introduce a user-facing change?: