Skip to content

fix path for canary by header + add e2e#365

Merged
k8s-ci-robot merged 8 commits intokubernetes-sigs:mainfrom
jgreeer:ingress-nginx/fix-canary-by-header-path
Mar 4, 2026
Merged

fix path for canary by header + add e2e#365
k8s-ci-robot merged 8 commits intokubernetes-sigs:mainfrom
jgreeer:ingress-nginx/fix-canary-by-header-path

Conversation

@jgreeer
Copy link
Copy Markdown
Contributor

@jgreeer jgreeer commented Feb 24, 2026

What type of PR is this?

added path support for canary by header

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 24, 2026

Hi @jgreeer. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 24, 2026
@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Feb 24, 2026

@jgreer could you add an integration test

@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Feb 25, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 25, 2026
@jgreeer jgreeer changed the title fix path for canary by header fix path for canary by header + add e2e Feb 25, 2026
@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Feb 26, 2026

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 26, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2026
bexxmodd
bexxmodd reviewed Mar 4, 2026
View reviewed changes
Comment thread pkg/i2gw/providers/ingressnginx/canary.go Outdated
neverRule := gatewayv1.HTTPRouteRule{
Matches: []gatewayv1.HTTPRouteMatch{neverMatch},
BackendRefs: []gatewayv1.HTTPBackendRef{nonCanaryBackendCopy},
}
Copy link
Copy Markdown

@bexxmodd bexxmodd Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic is repeated on lines 142-149. We can extract this into a helper function to reduce the size of canaryFeature function which is already quite long.

Copy link
Copy Markdown
Contributor Author

@jgreeer jgreeer Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will refactor this

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bexxmodd, jgreeer, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Stevenjin8
Copy link
Copy Markdown
Contributor

Stevenjin8 commented Mar 4, 2026

@bexxmodd can you lgtm

@bexxmodd
Copy link
Copy Markdown

bexxmodd commented Mar 4, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2026
@k8s-ci-robot k8s-ci-robot merged commit 8c6a974 into kubernetes-sigs:main Mar 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman LiorLieberman is a code owner

@robscott robscott Awaiting requested review from robscott robscott is a code owner

@Stevenjin8 Stevenjin8 Awaiting requested review from Stevenjin8 Stevenjin8 is a code owner

@youngnick youngnick Awaiting requested review from youngnick youngnick is a code owner

@spencerhance spencerhance Awaiting requested review from spencerhance

1 more reviewer

@bexxmodd bexxmodd bexxmodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bexxmodd bexxmodd

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgreeer @k8s-ci-robot @Stevenjin8 @bexxmodd