add envoy gateway e2e by kkk777-7 · Pull Request #372 · kubernetes-sigs/ingress2gateway

kkk777-7 · 2026-02-28T11:15:34Z

What type of PR is this?

/kind test

What this PR does / why we need it:
Add Envoy Gateway E2E test.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot · 2026-02-28T11:15:37Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Stevenjin8 · 2026-03-02T15:23:33Z

/approve

cc @johananl

k8s-ci-robot · 2026-03-03T09:17:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkk777-7, Stevenjin8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Stevenjin8,kkk777-7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Stevenjin8 · 2026-03-03T15:47:55Z

c @johananl could you take alook

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

Stevenjin8

/lgtm
/hold

In case you want to change how crds work and to give @johananl a chance to take a look

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

johananl

Thanks!

Other than the comment about the GWAPI CRD consts this looks great.

johananl · 2026-03-06T10:30:46Z

-func deployCRDs(ctx context.Context, l logger, client *apiextensionsclientset.Clientset, skipCleanup bool) (func(), error) {
-	l.Logf("Fetching manifests from %s", gatewayAPIInstallURL)
-	yamlData, err := fetchManifests(ctx, l)
+func deployCRDs(ctx context.Context, l logger, client *apiextensionsclientset.Clientset, url string, skipCleanup bool) (func(), error) {


I understand this change, there is a subtlety here: Before the change, this function was meant to be a helper fro installing the GWAPI CRDs specifically whereas now it's a generic helper for installing arbitrary CRDs.

What I suggest we do is move the gatewayAPIVersion and gatewayAPIInstallURL consts to gwapi.go. This way we turn crd.go into a truly generic helper file while keeping GWAPI-specific stuff in one place.

thanks, that makes sense! I've fixed.

johananl · 2026-03-06T10:47:33Z

+		_, err = gwClient.GatewayV1().GatewayClasses().Update(ctx, gc, metav1.UpdateOptions{})
+	}
+	if err != nil {
+		cleanupCRDs()


We're leaking the Helm chart here. This isn't a huge deal since we seem to have a general problem with this pattern (see #386) so please treat this comment as an FYI.

thanks, good catch!
After #366 merged, I'll tackle this issue when I have time.

I'll tackle this issue when I have time

Does "this issue" mean #386? Can we merge this (#372) PR?

yeah, I meant #386. I’d appreciate it if we could merge PR #372 first.

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

johananl · 2026-03-06T16:43:16Z

/lgtm
/unhold

johananl · 2026-03-06T16:44:40Z

Merged! Thanks for the contribution @kkk777-7 🙏

add envoy gateway e2e

e3e5795

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2026

k8s-ci-robot requested review from bexxmodd and spencerhance February 28, 2026 11:15

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2026

kkk777-7 temporarily deployed to release February 28, 2026 11:15 — with GitHub Actions Inactive

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 28, 2026

kkk777-7 marked this pull request as ready for review February 28, 2026 11:37

kkk777-7 requested review from LiorLieberman, Stevenjin8, robscott and youngnick as code owners February 28, 2026 11:37

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2026

k8s-ci-robot requested a review from rikatz February 28, 2026 11:37

set gateway namespace mode

f61cc08

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 temporarily deployed to release February 28, 2026 12:19 — with GitHub Actions Inactive

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2026

Stevenjin8 reviewed Mar 2, 2026

View reviewed changes

Comment thread e2e/gwapi_envoygateway.go Outdated

kkk777-7 temporarily deployed to release March 3, 2026 09:16 — with GitHub Actions Inactive

kkk777-7 force-pushed the e2e-eg branch from 771172e to f61cc08 Compare March 3, 2026 10:03

kkk777-7 temporarily deployed to release March 3, 2026 10:03 — with GitHub Actions Inactive

update: install envoy gateway crd separately

75c6bd2

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 temporarily deployed to release March 3, 2026 16:00 — with GitHub Actions Inactive

Stevenjin8 reviewed Mar 3, 2026

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026

k8s-ci-robot assigned Stevenjin8 Mar 3, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2026

fix golang lint

448f440

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2026

kkk777-7 temporarily deployed to release March 3, 2026 16:23 — with GitHub Actions Inactive

Stevenjin8 mentioned this pull request Mar 3, 2026

Reorganize e2e tests #366

Merged

johananl reviewed Mar 6, 2026

View reviewed changes

move gwapi consts

022335e

Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com>

kkk777-7 temporarily deployed to release March 6, 2026 16:06 — with GitHub Actions Inactive

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2026

k8s-ci-robot assigned johananl Mar 6, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2026

k8s-ci-robot merged commit d6206db into kubernetes-sigs:main Mar 6, 2026
6 checks passed

Conversation

kkk777-7 commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 28, 2026

Uh oh!

Stevenjin8 commented Mar 2, 2026

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 3, 2026

Uh oh!

Stevenjin8 commented Mar 3, 2026

Uh oh!

Stevenjin8 left a comment

Choose a reason for hiding this comment

Uh oh!

johananl left a comment

Choose a reason for hiding this comment

Uh oh!

johananl Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

kkk777-7 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

johananl Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

kkk777-7 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

johananl Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

kkk777-7 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

johananl commented Mar 6, 2026

Uh oh!

Uh oh!

johananl commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kkk777-7 commented Feb 28, 2026 •

edited

Loading