Feat/gke session cookie stacked pr 313 2#394
Merged
k8s-ci-robot merged 24 commits intokubernetes-sigs:mainfrom Mar 20, 2026
Merged
Feat/gke session cookie stacked pr 313 2#394k8s-ci-robot merged 24 commits intokubernetes-sigs:mainfrom
k8s-ci-robot merged 24 commits intokubernetes-sigs:mainfrom
Conversation
Signed-off-by: aashish kumar <aashtrek@google.com>
* remove copyright years after 2025 * change some other ocpyrights --------- Co-authored-by: Lior Lieberman <liorlib7+riskified@gmail.com>
…tes-sigs#375) * fix: use binary suffixes (Ki/Mi/Gi) for body size conversion * Fix tests and comment
* Some README updates for the ingress-nginx provider.for in * Fix readme * remove version stuff * remove comments in CONTRIBUTING.md * Better install instructions
* Move e2e logic to e2e/framework package Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Move providers and implementations to sub packages Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Consolidate Kong Kong is special in that it serves both as an ingress provider and a Gateway API implementation. However, having a separate helper for each deployment type is unnecessary and creates problems in some tests. Merge the two helpers into one while allowing importing the helper via both implementation.DeployKong and provider.DeployKong (via a thin wrapper) for consistency with other providers. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Use correct consts to identify providers and implementations deployProviders() matches ingress provider names defined in pkg/i2gw/providers — these must stay in sync with the library because they form the CLI contract. deployGatewayImplementation() decides which gateway backend to deploy — an e2e concern that pkg/i2gw has no idea about. Even when a provider and an implementation share the same string value (e.g. "kong"), the consts carry different meanings and should come from different packages so the two concerns don't get conflated. Use consts from pkg/i2gw/providers for the deployProviders switch and consts from e2e/implementation for the deployGatewayImplementation switch. Kong is a special case: it serves as both an ingress provider and a gateway implementation, backed by a single Helm deployment. Both code paths use the same Acquire key (implementation.KongName) so the resource manager deduplicates the deployment and avoids races between test cases. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Reorganize tests by category Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Update e2e/README.md Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Remove old comment This info lives under e2e/README.md now. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Fix slow-deleting namespaces Adding the Envoy Gateway implementation seems to have triggered a racy situation upon test teardown where some app namespaces get stuck in "Terminating" for multiple minutes despite not having any resources, likely due to transient errors which trigger exponential backoff. Fix the issue by watching for stuck namespaces and "nudging" the namespace controller by touching an annotation on the namespace object. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> * Generate kind.yaml dynamically No need to commit this file to the repo - we can generate it on the fly and remove at test cleanup. Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com> --------- Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
* Get rid of Info notifications * Make most errors notifications add regex warnings * use methods * lint * fmt * cleanup some warning messages * add more notifications * verify * fix test * grpcroute warnings * review
Stevenjin8
requested review from
LiorLieberman,
robscott and
youngnick
as code owners
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Stevenjin8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
size/L
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Stevenjin8
removed
the
do-not-merge/hold
Contributor
Author
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #313 so we can get this merged today.