change httproute name#79
Merged
k8s-ci-robot merged 3 commits intokubernetes-sigs:mainfrom Oct 30, 2023
Merged
Conversation
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
size/M
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
|
Thanks @mlavacca ! Looks good to me with +1 on Kobi's comment. /lgtm Ping me here once this fixed and I will approve it |
k8s-ci-robot
added
lgtm
mlavacca
force-pushed
the
rename-httproutes
branch
from
422ac51 to
8a245f9
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
rename-httproutes
branch
from
8a245f9 to
de893ab
Compare
Member
Author
|
/retest |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
@LiorLieberman lgtm label is missing as there were changes after your lgtm stamp. |
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
LiorLieberman
added
the
kind/feature
danehans
added a commit
to danehans/ingress2gateway
that referenced
this pull request
Jan 27, 2026
Flake: Only Call `FirstRouteHost()` When Header is Unset
rajashish
pushed a commit
to rajashish/ingress2gateway1
that referenced
this pull request
Feb 21, 2026
change httproute name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The
HTTPRoutesare named with the following pattern: <Ingress-name>-<name-from-host>. This helps users to immediately associate theHTTPRoute(s) created by the tool to the ingress the tool has taken as input.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: