Skip to content

Add support for Hubble flowlogs config #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Add support for Hubble flowlogs config #12064

wants to merge 5 commits into from

Conversation

ErmolenkoMaxim
Copy link
Contributor

@ErmolenkoMaxim ErmolenkoMaxim commented Mar 21, 2025 •
edited
Loading

/kind feature

What this PR does / why we need it:
Adds support for configuring Hubble flowlogs in Cilium via Kubespray inventory.
This allows users to declaratively define flow log filtering and output settings in hubble_flowlogs_config from their inventory.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Tested on Kubernetes 1.29 with Cilium 1.14.
Flowlogs configuration is properly mounted into the Cilium pods and validated.

Does this PR introduce a user-facing change?:

Kubespray now supports configuring advanced Hubble flow log settings for Cilium via the `hubble_flowlogs_config` inventory variable. The specified configuration is rendered as `flowlogs.yaml`, mounted into the Cilium pod, and used to customize flow log filters, output format, and export behavior.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 21, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 21, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ErmolenkoMaxim!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ErmolenkoMaxim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2025
@ErmolenkoMaxim
Copy link
Contributor Author

CLA signed.

@tico88612
Copy link
Member

@ErmolenkoMaxim It is still not signed. #12064 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 24, 2025
@ErmolenkoMaxim
Copy link
Contributor Author

@tico88612 fixed. Please proceed.

@tico88612
Copy link
Member

@ErmolenkoMaxim please fix your PR content about the release-note like this:

kubespray/.github/PULL_REQUEST_TEMPLATE.md

Lines 42 to 44 in 3ace896

```release-note
```

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2025
@ErmolenkoMaxim
Copy link
Contributor Author

@ErmolenkoMaxim please fix your PR content about the release-note like this:

kubespray/.github/PULL_REQUEST_TEMPLATE.md

Lines 42 to 44 in 3ace896

```release-note
```

sure. please check.

@VannTen
Copy link
Contributor

VannTen commented Apr 1, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/contains-merge-commits and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2025
@ErmolenkoMaxim ErmolenkoMaxim force-pushed the feature/hubble-flowlogs branch from bcdb38e to b7d9ab6 Compare April 2, 2025 08:56
@ErmolenkoMaxim
Copy link
Contributor Author

@VannTen retest?

@VannTen
Copy link
Contributor

VannTen commented Apr 7, 2025 via email

@ErmolenkoMaxim
Copy link
Contributor Author

@yankay @tico88612 please check

@ErmolenkoMaxim
Copy link
Contributor Author

@yankay @tico88612 kind reminder

@ErmolenkoMaxim
Copy link
Contributor Author

Check the pre-commit logs.

@VannTen could you please be more specific?

@tico88612
Copy link
Member

@ErmolenkoMaxim No promise review. Please check your pre-commit job for no errors. If there is no special reason, please fix it.

@ErmolenkoMaxim
Copy link
Contributor Author

ErmolenkoMaxim commented Apr 23, 2025 •
edited
Loading

@tico88612 pre-commit job checked and fixed. please proceed

@ErmolenkoMaxim
Copy link
Contributor Author

@tico88612 @yankay please proceed

yankay
yankay reviewed May 6, 2025
View reviewed changes
@ErmolenkoMaxim ErmolenkoMaxim requested a review from yankay May 7, 2025 09:21
@tico88612 tico88612 mentioned this pull request May 10, 2025
Merged
VannTen
VannTen reviewed May 17, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
@ErmolenkoMaxim ErmolenkoMaxim force-pushed the feature/hubble-flowlogs branch from 7c00c2a to 26acbd5 Compare May 20, 2025 11:10
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ErmolenkoMaxim
Once this PR has been reviewed and has the lgtm label, please assign ant31 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2025
@VannTen
Copy link
Contributor

VannTen commented May 20, 2025 via email

@ErmolenkoMaxim
Copy link
Contributor Author

Is this still relevant after #12101 merged ?

seems so.
I've made rebase and made corrections according your last requests

tico88612
tico88612 requested changes May 20, 2025
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you find the corresponding settings in the Cilium helm chart?

We'd deprecated the Cilium installation via Jinja template on #12101.

@ErmolenkoMaxim ErmolenkoMaxim deleted the feature/hubble-flowlogs branch May 21, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VannTen VannTen VannTen left review comments

@tico88612 tico88612 tico88612 requested changes

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ErmolenkoMaxim @k8s-ci-robot @tico88612 @VannTen @yankay