Skip to content

feat: add support for custom kubeadm image repository #12128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HoKim98
Copy link
Member

@HoKim98 HoKim98 commented Apr 12, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR adds support for kubeadm_image_repo variable to utilize custom kubernetes core images, such as kube-apiserver and kube-proxy.

Previously, to achieve this same functionality, we would have to use a variable called kube_image_repo. However, this would have affected the entire ecosystem, including nodelocaldns, scheduler_plugins, and csi_attacher. Instead, it is great for replacing registry.k8s.io, such as for air-gapped deployments.

However, it is not suitable for changing the image repository for Kubernetes itself. And it is unnecessary to change the repository for each image such as kube_apiserver, because these core services are shipped with the Kubernetes version (e.g. v1.32.3). Also, their existence is derived from kubeadm, so manual configuration is unnecessary. Therefore, the core of this PR is to add the ability to replace only the image repository used by kubeadm.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add support for `kubeadm_image_repo` variable to change kubernetes core image repository (e.g. `kube-apiserver`, `kube-proxy`).

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HoKim98
Once this PR has been reviewed and has the lgtm label, please assign liupeng0518 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2025
@HoKim98 HoKim98 changed the title feat: add support for custom kubeadm pull image repository feat: add support for custom kubeadm image repository Apr 12, 2025
@HoKim98 HoKim98 force-pushed the feat/add-support-for-custom-kubeadm-pull-image-repo branch from 94eea9b to f0d8fd8 Compare April 12, 2025 16:23
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why need the kubeadm_image_repo variable. I was under the impression that we had offline related operations? (in docs/)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants