Skip to content

Use last patch versions by default for etcd/crio/crictl #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

Use last patch versions by default for etcd/crio/crictl #12233

merged 1 commit into from
Jun 15, 2025

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented May 18, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This uses the same logic than the other versions, with simplications for
crictl and crio whose versionning scheme is tied to upstream kubernetes.

Also move some version variables in vars/ rather than defaults/, because
they are not used elsewhere and don't really make sense as modifiable by
the user.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

action required
drop support for cri-o on ubuntu20.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 18, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2025
@VannTen
Copy link
Contributor Author

VannTen commented May 18, 2025 via email

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch from 1c03044 to 040c76e Compare May 19, 2025 15:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch 3 times, most recently from ac66275 to 31a9a99 Compare May 20, 2025 07:39
@VannTen
Copy link
Contributor Author

VannTen commented May 20, 2025

Looks like the trigger of the bug is cri-o/cri-o#9162 (one of the two commits between 1.32.3 and 1.32.4) but I'm not sure why or how.
Maybe cri-o/cri-o#8083 is relevant 🤔

@VannTen
Copy link
Contributor Author

VannTen commented May 20, 2025

Plus I don't have pull access to the image used by the molecule tests (quay.io/kubespray/hello-world so not sure how to reproduce this 🤔

@VannTen VannTen marked this pull request as draft May 20, 2025 08:19
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@VannTen
Copy link
Contributor Author

VannTen commented May 20, 2025

Testing the same command with a local install (on archlinux crio 1.32.4 does not reproduce the error, the container start).
@tico88612 (as you added that test AFAICT) any ideas ? (after the release, this is not time sensitive)

@VannTen VannTen mentioned this pull request May 20, 2025
Merged
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch from 5440afc to 1460a1e Compare May 20, 2025 12:40
@VannTen
Copy link
Contributor Author

VannTen commented May 20, 2025

/retest

@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch 2 times, most recently from d89913a to 7e7b69a Compare May 20, 2025 15:08
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2025
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch 4 times, most recently from 06633b8 to 4b4b952 Compare May 20, 2025 15:47
@tmurakam
Copy link
Contributor

Thanks. I agree to dropping cri-o/Ubuntu 20.04 support.

@tmurakam
Copy link
Contributor

tmurakam commented May 21, 2025 •
edited
Loading

FYI.
I'm investigating the cause of crun issue.

  • The crio-o 1.32.4 release includes crun 1.21 and it seems not work with Ubuntu 20.04.
  • The crio-o 1.32.3 release includes crun 1.20 and it seems okay.

The crun is installed at /usr/libexec/crio/crun by container-engine/cri-o role and used by cri-o.
The /usr/local/bin/crun which is installed by container-engine/crun is not used at all.
(I think the cri-o role should not depends on crun role)

EDIT: I created a issue : #12250

@tmurakam tmurakam mentioned this pull request May 23, 2025
Open
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch from 4b4b952 to 4af5ff2 Compare June 5, 2025 09:14
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 5, 2025
@VannTen VannTen marked this pull request as ready for review June 5, 2025 09:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2025
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch from 4af5ff2 to 2aa81fc Compare June 6, 2025 08:07
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 6, 2025
tico88612
tico88612 reviewed Jun 6, 2025
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small question

@tico88612
Copy link
Member

/lgtm

But CI is broken now 😅

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@tico88612
Copy link
Member

/retest

1 similar comment
@tico88612
Copy link
Member

/retest

@tico88612
Copy link
Member

Need rebase (terraform removed)

@VannTen
Use last patch versions by default for etcd/crio/crictl
3259fb7 
This uses the same logic than the other versions, with simplications for
crictl and crio whose versionning scheme is tied to upstream kubernetes.

Also move some version variables in vars/ rather than defaults/, because
they are not used elsewhere and don't really make sense as modifiable by
the user.
@VannTen VannTen force-pushed the cleanup/auto_update_defaults branch from 2aa81fc to 3259fb7 Compare June 14, 2025 16:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2025
@VannTen VannTen requested a review from tico88612 June 14, 2025 20:30
tico88612
tico88612 approved these changes Jun 15, 2025
View reviewed changes
Copy link
Member

@tico88612 tico88612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 144742c into kubernetes-sigs:master Jun 15, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tico88612 tico88612 tico88612 approved these changes

@cyclinder cyclinder Awaiting requested review from cyclinder

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

@MrFreezeex MrFreezeex Awaiting requested review from MrFreezeex

Assignees

@tico88612 tico88612

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VannTen @tmurakam @tico88612 @k8s-ci-robot