kustomize 5.8.1 references generated configMaps and secrets incorrectly in Helm generated deployments

[mfredenhagen]

What happened?

kustomize v5.8.1 does not use the correct name of a generated configMap or secret when patching a deployment generated by Helm. It just uses the name without the hash. The same works flawlessly with kustomize v5.7.1
Please see the attached reproducer example.

kustomize-helm-configMap-reproducer.tgz

What did you expect to happen?

Same behaviour as in kustomize v5.7.1 and earlier.

How can we reproduce it (as minimally and precisely as possible)?

see attached files

Expected output

apiVersion: v1
data:
  config: foo
kind: ConfigMap
metadata:
  name: test-config-g46hh6k8tf
--
        secret:
          defaultMode: 292
          secretName: test-secret-gh24bh7t8g
      - configMap:
          defaultMode: 292
          name: test-config-g46hh6k8tf

Actual output

apiVersion: v1
data:
  config: foo
kind: ConfigMap
metadata:
  name: test-config-g46hh6k8tf
--
        secret:
          defaultMode: 292
          secretName: test-secret
      - configMap:
          defaultMode: 292
          name: test-config

Kustomize version

v5.8.1

Operating system

MacOS

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[koba1t]

I think this problem is related #6058
Maybe fixing #6058 will solve this problem.

[Skaronator]

Hi, sorry about breaking everything. With the fix in #6108 it is working again as expected.

/home/niklas/go/bin/kustomize build --enable-helm | grep -C 5 gh24bh7t8g
apiVersion: v1
data:
  secret: Zm9v
kind: Secret
metadata:
  name: test-secret-gh24bh7t8g
  namespace: cluster
type: Opaque
---
apiVersion: v1
kind: Service
--
      serviceAccountName: release-name-test-chart
      volumes:
      - name: test-secret
        secret:
          defaultMode: 292
          secretName: test-secret-gh24bh7t8g
      - configMap:
          defaultMode: 292
          name: test-config-g46hh6k8tf
        name: test-conf
---

[Skaronator]

/triage accepted
/assign

[k8s-ci-robot]

@Skaronator: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

Details

In response to this:

/triage accepted
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mfredenhagen]

Thank you @Skaronator! I've checked out your branch and built from source, and I confirm it works again (not only for the reproducer, but also in our own project).
Do you have an ETA? Currently, we are stuck on kustomize 5.7.1, which doesn't support Helm 4 :-(

[Skaronator]

@mfredenhagen can you comment in the PR and also approve it? That would probably help the most.