kyaml: mark ValidatingAdmissionPolicy resources as cluster-scoped#6056
kyaml: mark ValidatingAdmissionPolicy resources as cluster-scoped#6056HarshithaMS005 wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
|
|
Welcome @HarshithaMS005! |
|
Hi @HarshithaMS005. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: HarshithaMS005 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Harshitha MS <harshitha.ms@ibm.com>
972eb3e to
c05b2f3
Compare
Fixes #6051.
ValidatingAdmissionPolicy and ValidatingAdmissionPolicyBinding are cluster-scoped resources, but were missing from kyaml’s precomputed namespace scope map. As a result, NamespaceTransformer incorrectly injected metadata.namespace when a namespace was set in the kustomisation. This PR marks both resources as cluster-scoped and adds a regression test to ensure namespaces are not added to these admission registration APIs.