Fix volume mount source incorrectly converted to absolute path#6073
Fix volume mount source incorrectly converted to absolute path#6073tonobo wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
When using `kustomize build --enable-alpha-plugins` with a container transformer that specifies a Docker volume mount, the volume name (e.g. "my-volume") is incorrectly converted to an absolute host path (e.g. "/working/dir/my-volume"). This breaks the Docker --mount flag because a named volume is not a filesystem path. Skip the relative-to-absolute path conversion for volume type mounts, as their source represents a Docker volume name, not a host path. Follow up for commit: 9d5491c Issue kubernetes-sigs#6072
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @tonobo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chansuke, tonobo The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
When using
kustomize build --enable-alpha-pluginswith a container transformer that specifies a Docker volume mount, the volume name (e.g. "my-volume") is incorrectly converted to an absolute host path (e.g. "/working/dir/my-volume"). This breaks the Docker --mount flag because a named volume is not a filesystem path.Skip the relative-to-absolute path conversion for volume type mounts, as their source represents a Docker volume name, not a host path.
Follow up for commit: 9d5491c
Issue #6072
Related: