chore: build kustomize binary into _output/ directory#6095
chore: build kustomize binary into _output/ directory#6095xjohnyknox wants to merge 1 commit intokubernetes-sigs:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xjohnyknox The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @xjohnyknox. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| # goreleaser artifacts | ||
| **/dist/ | ||
| /output/ |
There was a problem hiding this comment.
| # goreleaser artifacts | |
| **/dist/ | |
| /output/ |
Seems like goreleaser isn't used anymore. Looks like it was removed in #5239
make kustomizecurrently doesgo install, putting the binary in$GOBIN. This changes it to usego build -o _output/kustomizeinstead, keeping the binary in the repo tree like k/k does with_output/bin/._output/gets prepended toPATHso existing make targets that depend on the binary still work.make cleanwipes it.I verified the target resolves correctly and the existing test/e2e targets pick up the binary from the new path.
Fixes #5347