Skip to content

chore: build kustomize binary into _output/ directory#6095

Open
xjohnyknox wants to merge 1 commit intokubernetes-sigs:masterfrom
xjohnyknox:chore/build-output-directory
Open

chore: build kustomize binary into _output/ directory#6095
xjohnyknox wants to merge 1 commit intokubernetes-sigs:masterfrom
xjohnyknox:chore/build-output-directory

Conversation

@xjohnyknox
Copy link
Copy Markdown

@xjohnyknox xjohnyknox commented Mar 13, 2026

make kustomize currently does go install, putting the binary in $GOBIN. This changes it to use go build -o _output/kustomize instead, keeping the binary in the repo tree like k/k does with _output/bin/.

_output/ gets prepended to PATH so existing make targets that depend on the binary still work. make clean wipes it.

I verified the target resolves correctly and the existing test/e2e targets pick up the binary from the new path.

Fixes #5347

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xjohnyknox
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 13, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @xjohnyknox. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2026
@sarab97
Copy link
Copy Markdown
Member

sarab97 commented Mar 26, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2026
Comment thread .gitignore
Comment on lines 32 to 34
# goreleaser artifacts
**/dist/
/output/
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# goreleaser artifacts
**/dist/
/output/

Seems like goreleaser isn't used anymore. Looks like it was removed in #5239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Store Kustomize Binaries in _output/ Directory for Consistency, Same Like K/K.

4 participants