fix(api/types): map HelmChartArgs.ReleaseNamespace -> HelmChart.Namespace

[SAY-5]

Fixes #4593.

Problem

Kustomizations using the (deprecated) helmChartInflationGenerator field with releaseNamespace silently emit resources into the default namespace instead of the requested one:

helmChartInflationGenerator:
  - chartName: nats
    chartVersion: v0.13.1
    chartRepoUrl: https://nats-io.github.io/k8s/helm/charts
    releaseName: nats
    releaseNamespace: custom-ns   # ← ignored

Root cause

SplitHelmParameters translates every HelmChartArgs (deprecated) into a HelmChart (current) via makeHelmChartFromHca. That translator was missing one field:

func makeHelmChartFromHca(old *HelmChartArgs) (c HelmChart) {
    c.Name         = old.ChartName
    c.Version      = old.ChartVersion
    c.Repo         = old.ChartRepoURL
    c.ValuesFile   = old.Values
    c.ValuesInline = old.ValuesLocal
    c.ValuesMerge  = old.ValuesMerge
    c.ReleaseName  = old.ReleaseName
    // <-- ReleaseNamespace was never copied onto c.Namespace
    return
}

HelmChart.Namespace is what later gets passed as --namespace to helm template in AsHelmArgs, so when it was left empty the chart was rendered against default.

Fix

Copy old.ReleaseNamespace into c.Namespace. One-line change; preserves full backward compatibility with any user that was relying on the broken behaviour (they were never getting the namespace they asked for in the first place).

Test

Added TestSplitHelmParametersPropagatesReleaseNamespace in api/types/helmchartargs_test.go, which directly asserts the mapping:

args := []types.HelmChartArgs{{
    ChartName:        "nats",
    ChartVersion:     "v0.13.1",
    ReleaseName:      "nats",
    ReleaseNamespace: "custom-ns",
}}
charts, _ := types.SplitHelmParameters(args)
require.Equal(t, "custom-ns", charts[0].Namespace)

Signed-off per DCO.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SAY-5
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @SAY-5!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @SAY-5. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sarab97]

/ok-to-test

[sarab97]

This comment seems unnecessary.

[SAY-5]

Good point, dropped that comment.