Skip to content

feat(build): flag -strict-warnings to enforce policy failures#6139

Open
manute wants to merge 1 commit into
kubernetes-sigs:masterfrom
manute:master
Open

feat(build): flag -strict-warnings to enforce policy failures#6139
manute wants to merge 1 commit into
kubernetes-sigs:masterfrom
manute:master

Conversation

@manute

@manute manute commented May 5, 2026

Copy link
Copy Markdown

Reference: #6040

I just wanted to check first if this approach is ok with you, and then I can add more tests, docs , etc.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manute
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 5, 2026
@k8s-ci-robot
k8s-ci-robot requested a review from sarab97 May 5, 2026 16:25
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 5, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @manute. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 5, 2026
@koba1t

koba1t commented May 7, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2026
@manute

manute commented May 7, 2026

Copy link
Copy Markdown
Author

/retest-required

@manute manute changed the title Add flag -warnings-as-errors to enforce policy failures Add flag -strict-warnings to enforce policy failures May 7, 2026
@manute manute changed the title Add flag -strict-warnings to enforce policy failures feat(build): flag -strict-warnings to enforce policy failures May 7, 2026
Signed-off-by: Manuel Alonso <434575+manute@users.noreply.github.com>
@manute

manute commented May 14, 2026

Copy link
Copy Markdown
Author

@koba1t wdyt? can you run ok tests again please? thanks

@manute

manute commented Jun 6, 2026

Copy link
Copy Markdown
Author

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants