Skip to content

Fix helm chart rendering without values file#6145

Open
Zakharden wants to merge 1 commit into
kubernetes-sigs:masterfrom
Zakharden:fix/helm-chart-without-values
Open

Fix helm chart rendering without values file#6145
Zakharden wants to merge 1 commit into
kubernetes-sigs:masterfrom
Zakharden:fix/helm-chart-without-values

Conversation

@Zakharden

Copy link
Copy Markdown

Fixes Helm chart rendering when chart has no implicit values.yaml, while preserving errors for explicitly missing files. Validation: targeted go test ./api/krusty ..., git diff --check.

Signed-off-by: Zakhar Dvurechensky <72825626+Zakharden@users.noreply.github.com>
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @Zakharden!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @Zakharden. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zakharden
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from koba1t and sarab97 May 12, 2026 10:08
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 12, 2026
@Zakharden

Copy link
Copy Markdown
Author

Could a Kubernetes SIGs member please verify this PR for testing with /ok-to-test when available?

The change is focused on Helm chart rendering when a chart has no implicit values.yaml, while preserving errors for explicitly missing values files. I validated it locally with the targeted go test ./api/krusty ... coverage noted in the PR description.
@koba1t @sarab97

@Zakharden

Copy link
Copy Markdown
Author

@koba1t @sarab97, give /ok-to-test plzzz

@Zakharden

Copy link
Copy Markdown
Author

Quick nudge: this PR is still focused and ready for verification.
I rechecked local behavior around chart rendering when values file is missing + erroring when explicitly missing.
Could you please run path in bot by commenting so CI can proceed? / @koba1t @sarab97

@Zakharden

Copy link
Copy Markdown
Author

Quick nudge: this PR is still focused and ready for verification. Could you please rerun your test flow so CI can proceed; thanks.

@Zakharden

Copy link
Copy Markdown
Author

/ok-to-test is still required on this PR by your bot policy. No code changes from my side at this moment; once it is enabled I can push another no-op if needed for re-trigger.

@Zakharden

Copy link
Copy Markdown
Author

No additional code changes were made after the last request. This PR is still blocked by bot policy as needs ok-to-test/approval workflow state.

I have not touched /lgtm as requested; please add approvals/verification (/ok-to-test) so regular CI can proceed.

@Zakharden

Copy link
Copy Markdown
Author

Thanks for staying with this PR. I’ve not made additional code changes since last update; it remains blocked by /bot verification () and I have not touched . Please run approval/ok-to-test path so CI can proceed.

@Zakharden

Copy link
Copy Markdown
Author

I’ve not made new code changes since the last update. This PR is still waiting on maintainer bot flow (needs-ok-to-test / approval path remains required), and I have not touched /lgtm. Please run the approval flow so CI can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants