Skip to content

api/krusty: add SuppressDeprecationWarnings option to suppress lib warnings#6159

Open
santoshguru-11 wants to merge 1 commit into
kubernetes-sigs:masterfrom
santoshguru-11:fix/suppress-deprecation-warnings-lib
Open

api/krusty: add SuppressDeprecationWarnings option to suppress lib warnings#6159
santoshguru-11 wants to merge 1 commit into
kubernetes-sigs:masterfrom
santoshguru-11:fix/suppress-deprecation-warnings-lib

Conversation

@santoshguru-11

Copy link
Copy Markdown

Summary

When kustomize is used as a Go library (calling krusty.MakeKustomizer(...).Run(...)), deprecation warnings for fields like bases, vars, patchesJson6902, patchesStrategicMerge, commonLabels, etc. are unconditionally written to os.Stderr. Library consumers that control their own output have no way to silence this noise.

Changes

  • Add SuppressDeprecationWarnings bool to krusty.Options
  • Thread the option through to KustTarget via a new SetSuppressDeprecationWarnings setter
  • Skip the fmt.Fprintf(os.Stderr, ...) calls in KustTarget.Load() when the option is true
  • Default is false — no change in behavior for existing callers

Test

Added TestSuppressDeprecationWarnings in api/krusty/kustomizer_test.go that:

  1. Builds a kustomization using the deprecated bases field and asserts a warning appears on stderr by default
  2. Repeats the same build with SuppressDeprecationWarnings: true and asserts stderr is empty

Fixes

Fixes #5452

When kustomize is used as a Go library, deprecation warnings about fields
like 'bases', 'vars', 'patchesJson6902', etc. are printed to os.Stderr
unconditionally. For library consumers that manage their own output, this
produces unwanted noise that cannot be suppressed.

Add SuppressDeprecationWarnings bool to krusty.Options. When true, the
fmt.Fprintf(os.Stderr, ...) calls inside KustTarget.Load are skipped.
The default is false, preserving existing behavior.

Fixes kubernetes-sigs#5452

Signed-off-by: santoshguru-11 <darbhasantosh11@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 2, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

  • 92c598e api/krusty: add SuppressDeprecationWarnings option to Build API

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @santoshguru-11!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @santoshguru-11. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: santoshguru-11
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option in kustomize lib to suppress the deprecation warnings.

2 participants