fix: occasional minified JSON from GitHub release API

[EdwardCooke]

The github releases API occasionally returns a minified JSON object. The original grep command works when each browser_download_url was on the same line, but with a minified blob it returns the last quoted string, which is the URL to the release itself.

Fixes #6163

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: EdwardCooke / name: Edward Cooke (92b3eeb)

[k8s-ci-robot]

Welcome @EdwardCooke!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @EdwardCooke. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EdwardCooke
Once this PR has been reviewed and has the lgtm label, please assign koba1t for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the kustomize install helper to extract the latest matching asset download URL more reliably from the GitHub releases payload.

Changes:

• Extract browser_download_url values explicitly instead of grepping whole JSON lines.
• Filter extracted URLs by ${opsys}_${arch} before selecting the latest via version-sort.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[EdwardCooke]

FYI, the response from github to a similar question about minified vs not.

https://github.com/orgs/community/discussions/189605

[koba1t]

/ok-to-test

[koba1t]

@EdwardCooke

I think we need to fix this problem.
Could you please add tests to verify that this fix is ​​sufficient and does not break existing functionality?

[EdwardCooke]

@koba1t i ran a bunch of tests against both minified and non-minified json on Mac and Linux. They all produced the same result. Do you want it automated so it runs everytime a build kicks off?

[koba1t]

Up until now, simply running install_kustomize.sh and verifying that the binary was downloaded was considered a sufficient test.
However, surely that is not enough for the changes proposed in this PR, is it?

While it may not be necessary to run it during every CI execution, we do need a way to verify that this functionality remains intact whenever the script is modified.

[EdwardCooke]

I’ll work on that over the next few days. How would you like me to go about it? One idea I have is keep a copy of both minified and unminified files in the repo and use an environment variable to tell it to read the files instead of downloading them.

Trying to reproduce the problem was very time consuming and didn’t always work so my recommendation is we find at least someway to read both good and bad release files.

[kubernetes-prow]

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[EdwardCooke]

@koba1t I have added a way of testing the releases file through an environment variable. I also added a github action that will run only when the test files or the install_kustomize script are modified.

[EdwardCooke]

@koba1t this latest commit should have fixed the test workflow.

[koba1t]

@EdwardCooke
Thank you for your contribution!

/lgtm
/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EdwardCooke, koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [koba1t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment