Skip to content

feat: add support for OCI helm charts digest pinning#6182

Open
tollsimy wants to merge 1 commit into
kubernetes-sigs:masterfrom
tollsimy:feat/helm-digest
Open

feat: add support for OCI helm charts digest pinning#6182
tollsimy wants to merge 1 commit into
kubernetes-sigs:masterfrom
tollsimy:feat/helm-digest

Conversation

@tollsimy

@tollsimy tollsimy commented Jul 6, 2026

Copy link
Copy Markdown

close: #6155

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 6, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: tollsimy / name: Simone Tollardo (3f0df2d)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @tollsimy!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @tollsimy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tollsimy
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 6, 2026
@tollsimy
tollsimy force-pushed the feat/helm-digest branch from 3f0df2d to 9e55650 Compare July 6, 2026 15:31
Comment thread api/types/helmchartargs.go Outdated
- name: external-dns
repo: oci://registry-1.docker.io/bitnamicharts
version: 6.19.2
digest: sha256:694786e61c13cfa2ef89f8a0407d136a88c20c368f12ac2ada1c831ae520d28c

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would keep it similar how docker and other OCI tools treat versions and digest in a single field with the <version>@sha syntax but looks like helm itself will probably use seperate fields as well. So this is fine. Maybe it makes sense to wait a bit longer for the HIP to finalize?

helm/helm#32133
https://github.com/helm/community/pull/441/changes
https://github.com/helm/helm/pull/32142/changes#diff-dbbed30713935982e88e0e2cea901d8ba96b4a7de12e8067f3fe1d2a800df88dR39

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @Skaronator!
I'd also like to be as consistent as possible with Helm.

I responded to the HIP thread, let's see how that goes.

Signed-off-by: Simone Tollardo <dev@tollsimy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add OCI helm charts digest pinning

2 participants