feat: add support for OCI helm charts digest pinning#6182
Conversation
|
|
|
Welcome @tollsimy! |
|
Hi @tollsimy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tollsimy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3f0df2d to
9e55650
Compare
| - name: external-dns | ||
| repo: oci://registry-1.docker.io/bitnamicharts | ||
| version: 6.19.2 | ||
| digest: sha256:694786e61c13cfa2ef89f8a0407d136a88c20c368f12ac2ada1c831ae520d28c |
There was a problem hiding this comment.
Personally I would keep it similar how docker and other OCI tools treat versions and digest in a single field with the <version>@sha syntax but looks like helm itself will probably use seperate fields as well. So this is fine. Maybe it makes sense to wait a bit longer for the HIP to finalize?
helm/helm#32133
https://github.com/helm/community/pull/441/changes
https://github.com/helm/helm/pull/32142/changes#diff-dbbed30713935982e88e0e2cea901d8ba96b4a7de12e8067f3fe1d2a800df88dR39
There was a problem hiding this comment.
Thanks for the feedback @Skaronator!
I'd also like to be as consistent as possible with Helm.
I responded to the HIP thread, let's see how that goes.
Signed-off-by: Simone Tollardo <dev@tollsimy.net>
9e55650 to
0153090
Compare
close: #6155