Skip to content

bump/go v1.26.5#6186

Merged
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:masterfrom
koba1t:bump/go_v1.26.5
Jul 11, 2026
Merged

bump/go v1.26.5#6186
kubernetes-prow[bot] merged 2 commits into
kubernetes-sigs:masterfrom
koba1t:bump/go_v1.26.5

Conversation

@koba1t

@koba1t koba1t commented Jul 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2026
@koba1t
koba1t force-pushed the bump/go_v1.26.5 branch from 6c84ac0 to 9bd009f Compare July 10, 2026 22:42
@kubernetes-prow kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2026
Comment thread api/go.mod
module sigs.k8s.io/kustomize/api

go 1.25.0
go 1.26.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is raising the go directive to 1.26 intentional? I'm wondering if kustomize wants to use new feature introduced in Go1.26. If not, I prefer to bump Go runtime version but keep the go directive version as-is.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository has many dependencies, and updating those dependencies may require updating the Go version, making the dependency update process complicated.

Therefore, we decided to automatically upgrade to the latest go1.x.0 whenever the runtime version is upgraded.

@musaprg

musaprg commented Jul 11, 2026

Copy link
Copy Markdown
Member

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit f39f952 into kubernetes-sigs:master Jul 11, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants