Reduce peak memory during edge grouping#1772
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Mar 5, 2026
Merged
Reduce peak memory during edge grouping#1772k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
do-not-merge/release-note-label-needed
k8s-ci-robot
added
the
area/artifacts
k8s-ci-robot
added
approved
Delete edges from the input map while iterating to free memory as new data structures are built. This halves peak memory usage during groupEdgesByIdentityDigest and CheckOverlappingEdges (~1.4GB to ~700MB with ~1M edges). Safe because Go allows map deletion during range, and all callers do not use the edges map after these functions return. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
saschagrunert
force-pushed
the
reduce-grouping-peak-memory
branch
from
2cb0707 to
f44c391
Compare
Member
Author
|
PTAL @kubernetes-sigs/release-engineering |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Delete edges from the input map while iterating to free memory as new data structures are built. This halves peak memory usage during
groupEdgesByIdentityDigestandCheckOverlappingEdges(~1.4GB to ~700MB with ~1M edges).Safe because Go allows map deletion during
range, and all callers do not use the edges map after these functions return.Related: kubernetes/test-infra#36582
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?