Fix promotion timeout when prow diff contains no digests#1798
Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom Mar 27, 2026
Merged
Conversation
When --use-prow-manifest-diff is enabled and the triggering commit only modifies promoter-manifest.yaml (without touching images.yaml), diffProwFiles returns an empty digest list. The filtering in ParseThinManifestFromFile was skipped for empty lists, causing the promoter to load all images across all staging projects. The subsequent sequential provenance verification for 900+ images caused the job to hit the 4h timeout. Return early with an empty manifest set when prow diff mode is active but no digests are found. Also stop the pipeline cleanly when ParseManifests returns no manifests. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/artifacts
saschagrunert
added a commit
to saschagrunert/test-infra
that referenced
this pull request
Mar 27, 2026
Use the staging latest image to pick up the fix for the promotion timeout when prow diff contains no digests (kubernetes-sigs/promo-tools#1798). Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
cpanato
approved these changes
Mar 27, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When
--use-prow-manifest-diffis enabled and the triggering commit only modifiespromoter-manifest.yaml(without touchingimages.yaml),diffProwFilesreturns an empty digest list. The filtering inParseThinManifestFromFilewas skipped for empty lists, causing the promoter to load all images across all staging projects. The subsequent sequential provenance verification for 900+ images caused the job to hit the 4h timeout.This was observed in kubernetes/k8s.io#9260, which blocked all subsequent
post-k8sio-image-promoruns.The fix returns early with an empty manifest set when prow diff mode is active but no digests are found, and stops the pipeline cleanly when
ParseManifestsreturns no manifests.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?