Synchronize automatically kube-proxy images#395
Conversation
|
Welcome @juanluisvaladas! |
80c04e4 to
d6d9775
Compare
| SUFFIX="-calico-hostprocess" | ||
| MISSING=() | ||
|
|
||
| # Fetch all kube-proxy tags from registry.k8s.io |
There was a problem hiding this comment.
This logic is a direct translation from test-kube-proxy-images.ps1
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - name: Login to DockerHub |
There was a problem hiding this comment.
This shouldn't be necessary, but I added it to prevent rate limiting just in case. I don't know if rate limiting is a real potential issue but the cost is mininal anyway.
Add a new scheduled workflow (sync-kube-proxy-images.yaml) that runs daily at 00:00 UTC (2 hours before test-kube-proxy-images.yml) to detect missing kube-proxy images starting 1.33 (currently the oldest supported kubernetes version). For each missing version it trigges build-kube-proxy-images.yml via workflow_dispatch. Also updates build-kube-proxy-images.yml so that the repository is now a configurable input so that changes can be tested on local branches. Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
d6d9775 to
d274286
Compare
|
@juanluisvaladas - Can you disable the cron schedule for https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/.github/workflows/test-kube-proxy-images.yaml too? We can keep the workflow around for a few weeks but it shouldn't be needed with these changes! |
|
/lgtm, just wondering if we will need to add clean up the old version of kubeproxy images? the doc hub we used is a free plan so it might have strict quota limitation? |
I believe the quota is for image pulls and not image storage. |
agree |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanluisvaladas, zylxjtu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey, sure I'm out of office but I'll do it next week. |
Reason for PR:
Currently the build-kube-proxy-images.yml workflow must be triggered manually, this PR automates that task so that it's made automatically for every new version. We only check versions starting on 1.33 because it's the oldest maintained branch.
This was tested here: https://github.com/juanluisvaladas/sig-windows-tools/actions/runs/22623814294/job/65555151567#step:4:62
In this test we can see the images for 1.35 not being triggered because they existed from previous execution runs and we see the workflows dispatched for the missing images.
Requirements
Notes:
Tested manually and I don't think docs are required for this change.