Skip to content

Synchronize automatically kube-proxy images#395

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
juanluisvaladas:automate-kube-proxy-image-build
Mar 13, 2026
Merged

Synchronize automatically kube-proxy images#395
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
juanluisvaladas:automate-kube-proxy-image-build

Conversation

@juanluisvaladas
Copy link
Copy Markdown
Contributor

@juanluisvaladas juanluisvaladas commented Mar 3, 2026

Reason for PR:

Currently the build-kube-proxy-images.yml workflow must be triggered manually, this PR automates that task so that it's made automatically for every new version. We only check versions starting on 1.33 because it's the oldest maintained branch.

This was tested here: https://github.com/juanluisvaladas/sig-windows-tools/actions/runs/22623814294/job/65555151567#step:4:62

In this test we can see the images for 1.35 not being triggered because they existed from previous execution runs and we see the workflows dispatched for the missing images.

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

Tested manually and I don't think docs are required for this change.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Mar 3, 2026
@k8s-ci-robot k8s-ci-robot requested review from marosset and zylxjtu March 3, 2026 12:29
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @juanluisvaladas!

It looks like this is your first PR to kubernetes-sigs/sig-windows-tools 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-windows-tools has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2026
@juanluisvaladas juanluisvaladas force-pushed the automate-kube-proxy-image-build branch from 80c04e4 to d6d9775 Compare March 3, 2026 12:33
SUFFIX="-calico-hostprocess"
MISSING=()

# Fetch all kube-proxy tags from registry.k8s.io
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic is a direct translation from test-kube-proxy-images.ps1

steps:
- uses: actions/checkout@v2

- name: Login to DockerHub
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary, but I added it to prevent rate limiting just in case. I don't know if rate limiting is a real potential issue but the cost is mininal anyway.

Add a new scheduled workflow (sync-kube-proxy-images.yaml) that runs
daily at 00:00 UTC (2 hours before test-kube-proxy-images.yml) to detect
missing kube-proxy images starting 1.33 (currently the oldest supported
kubernetes version). For each missing version it trigges
build-kube-proxy-images.yml via workflow_dispatch.

Also updates build-kube-proxy-images.yml so that the repository is now a
configurable input so that changes can be tested on local branches.

Signed-off-by: Juan-Luis de Sousa-Valadas Castaño <jvaladas@mirantis.com>
@juanluisvaladas juanluisvaladas force-pushed the automate-kube-proxy-image-build branch from d6d9775 to d274286 Compare March 3, 2026 12:48
@marosset
Copy link
Copy Markdown
Contributor

@juanluisvaladas - Can you disable the cron schedule for https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/.github/workflows/test-kube-proxy-images.yaml too?

We can keep the workflow around for a few weeks but it shouldn't be needed with these changes!

@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented Mar 11, 2026

/lgtm, just wondering if we will need to add clean up the old version of kubeproxy images? the doc hub we used is a free plan so it might have strict quota limitation?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2026
@marosset
Copy link
Copy Markdown
Contributor

/lgtm, just wondering if we will need to add clean up the old version of kubeproxy images? the doc hub we used is a free plan so it might have strict quota limitation?

I believe the quota is for image pulls and not image storage.
If we do need to add some sort of image cleanup I think it is OK to do that as a follow-up PR

@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented Mar 13, 2026

/lgtm, just wondering if we will need to add clean up the old version of kubeproxy images? the doc hub we used is a free plan so it might have strict quota limitation?

I believe the quota is for image pulls and not image storage. If we do need to add some sort of image cleanup I think it is OK to do that as a follow-up PR

agree

@zylxjtu
Copy link
Copy Markdown
Contributor

zylxjtu commented Mar 13, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2026
@k8s-ci-robot k8s-ci-robot merged commit 77474f5 into kubernetes-sigs:master Mar 13, 2026
2 checks passed
@juanluisvaladas
Copy link
Copy Markdown
Contributor Author

@juanluisvaladas - Can you disable the cron schedule for https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/.github/workflows/test-kube-proxy-images.yaml too?

We can keep the workflow around for a few weeks but it shouldn't be needed with these changes!

Hey, sure I'm out of office but I'll do it next week.

@marosset marosset mentioned this pull request Mar 17, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants