Skip to content

Enable concurrent workers for tagging controller#1126

Merged
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
shiv-amz:concurrent_worker
Mar 28, 2025
Merged

Enable concurrent workers for tagging controller#1126
k8s-ci-robot merged 3 commits into
kubernetes:masterfrom
shiv-amz:concurrent_worker

Conversation

@shiv-amz
Copy link
Copy Markdown
Contributor

@shiv-amz shiv-amz commented Mar 28, 2025

/kind feature

What this PR does / why we need it:

  • Tagging controller currently operates as a single-threaded process, leading to a backlog when processing nodes in larger clusters. PR introduces tagging-controller-concurrent-node-syncs option, allowing multiple parallel workers to pull from the work queue.
  • Testing with 1,000 nodes at a concurrency level of 10, over 50% of the nodes are tagged in under 1 second. In contrast, with single concurrency, 90% of the nodes take between 1 to 10 seconds to be tagged.
A new command-line flag, `tagging-controller-concurrent-node-syncs`, allows more than one node to be processed at once.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @shiv-amz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from hakman and mmerkes March 28, 2025 03:14
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2025
@cartermckinnon
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 28, 2025
@cartermckinnon
Copy link
Copy Markdown
Contributor

/triage accepted
/kind feature

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 28, 2025
@shiv-amz
Copy link
Copy Markdown
Contributor Author

/retest

@cartermckinnon
Copy link
Copy Markdown
Contributor

CI account has hit a service quota:

   I0328 06:38:39.671578 87733 dump.go:53] At 2025-03-28 06:38:16 +0000 UTC - event for svc-proxy-terminating: {service-controller } SyncLoadBalancerFailed: Error syncing load balancer: failed to ensure load balancer: error authorizing security group ingress: "RulesPerSecurityGroupLimitExceeded: The maximum number of rules per security group has been reached.\n\tstatus code: 400, request id: 10e8ee61-8c6d-4f66-8845-0872eced910c" 

Seeing if we can get it resolved, if not we can override...

@cartermckinnon
Copy link
Copy Markdown
Contributor

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@shiv-amz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-aws-e2e-kubetest2 b586c99 link false /test pull-cloud-provider-aws-e2e-kubetest2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cartermckinnon
Copy link
Copy Markdown
Contributor

Test flakes are not related to this change, going to continue looking into those out of band.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cartermckinnon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@k8s-ci-robot k8s-ci-robot merged commit 212135d into kubernetes:master Mar 28, 2025
4 of 5 checks passed
k8s-ci-robot added a commit that referenced this pull request Apr 25, 2025
…1120-#1126-upstream-release-1.32

Automated cherry pick of #1116: feat: add tagging controller delays and work queue size
#1120: Batch tagging controller create/delete tags calls
#1126: Enable concurrent worker syncs for tagging controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants