fix: reduce log verbosity of tagging controller#1154
Conversation
k8s-ci-robot
added
needs-kind
|
This issue is currently awaiting triage. If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
removed
the
needs-kind
k8s-ci-robot
added
the
size/XS
| // (since the node won't have the labels yet) and hence prevents us from making an unnecessary EC2 call. | ||
| if !tc.isTaggingRequired(node) { | ||
| klog.Infof("Skip putting node %s in work queue since it was already tagged earlier.", node.GetName()) | ||
| klog.V(3).Infof("Skip putting node %s in work queue since it was already tagged earlier.", node.GetName()) |
There was a problem hiding this comment.
This will be logged for every Node, every time its status is updated by kubelet (every 5 minutes by default). With many nodes, this creates a ton of noise in the CCM logs.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
The tagging controller log's are quite chatty, and this can cause issues in large clusters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: