Skip to content

e2e/debug: increase verbosity on test case failures#1217

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
mtulio:e2e-debug
Aug 1, 2025
Merged

e2e/debug: increase verbosity on test case failures#1217
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
mtulio:e2e-debug

Conversation

@mtulio
Copy link
Copy Markdown
Contributor

@mtulio mtulio commented Jul 29, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This change increase e2e verbosity on test case failures helping to detect what is going on with the resource by collecting service events and controller logs.

This was used to troubleshoot failures on #1214

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 29, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 29, 2025

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from dims and nckturner July 29, 2025 14:08
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 29, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 29, 2025

Hi @mtulio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2025
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Jul 29, 2025

cc @elmiko @kmala

@mtulio mtulio mentioned this pull request Jul 30, 2025
Merged
2 tasks
@cartermckinnon
Copy link
Copy Markdown
Contributor

cartermckinnon commented Jul 31, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2025
@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Jul 31, 2025

interesting, I am observing e2e jobs frequently getting stuck on the same phase (installing /kubetest2-kops), let me retry:
/test pull-cloud-provider-aws-e2e

@mtulio
Copy link
Copy Markdown
Contributor Author

mtulio commented Jul 31, 2025

e2e is passing, would you mind taking a look, @cartermckinnon ? Thanks!

elmiko
elmiko reviewed Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a nice helper to debug test failures

@kmala
Copy link
Copy Markdown
Member

kmala commented Aug 1, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Aug 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit e955e76 into kubernetes:master Aug 1, 2025
11 checks passed
@mtulio mtulio deleted the e2e-debug branch August 1, 2025 01:18
This was referenced Dec 9, 2025
Merged
Merged
Merged
@vitrixLab vitrixLab mentioned this pull request Jan 12, 2026
Closed
k8s-ci-robot added a commit that referenced this pull request Jan 21, 2026
@k8s-ci-robot
Merge pull request #1317 from kmala/automated-cherry-pick-of-#1153-#1161
e8344fd 
-#1215-#1217-#1214-upstream-release-1.32

Automated cherry pick of #1153: e2e/deps: enhance test scenarios with NLB
#1161: e2e/loadbalancer: implement hairpin connection cases
#1215: refact: e2e tests documenting hooks and enhance logging/steps
#1217: e2e/debug: increase data collection on e2e failures
#1214: doc/service: describe supported target group attributes
k8s-ci-robot added a commit that referenced this pull request Jan 21, 2026
@k8s-ci-robot
Merge pull request #1315 from kmala/automated-cherry-pick-of-#1153-#1161
6c5a136 
-#1215-#1217-#1214-upstream-release-1.33

Automated cherry pick of #1153: e2e/deps: enhance test scenarios with NLB
#1161: e2e/loadbalancer: implement hairpin connection cases
#1215: refact: e2e tests documenting hooks and enhance logging/steps
#1217: e2e/debug: increase data collection on e2e failures
#1214: doc/service: describe supported target group attributes
k8s-ci-robot added a commit that referenced this pull request Jan 21, 2026
@k8s-ci-robot
Merge pull request #1318 from kmala/automated-cherry-pick-of-#1153-#1161
c70e4ac 
-#1215-#1217-#1214-upstream-release-1.31

Automated cherry pick of #1153: e2e/deps: enhance test scenarios with NLB
#1161: e2e/loadbalancer: implement hairpin connection cases
#1215: refact: e2e tests documenting hooks and enhance logging/steps
#1217: e2e/debug: increase data collection on e2e failures
#1214: doc/service: describe supported target group attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims Awaiting requested review from dims

@nckturner nckturner Awaiting requested review from nckturner

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtulio @k8s-ci-robot @cartermckinnon @kmala @elmiko