Skip to content

1.35.0 release#1320

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Ganiredi:v1.35.0
Dec 22, 2025
Merged

1.35.0 release#1320
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Ganiredi:v1.35.0

Conversation

@Ganiredi
Copy link
Copy Markdown
Contributor

@Ganiredi Ganiredi commented Dec 18, 2025

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 18, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 18, 2025

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 18, 2025

Hi @Ganiredi. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
kmala
kmala reviewed Dec 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kmala kmala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the test/e2e package go.mod file

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
@kmala
Copy link
Copy Markdown
Member

kmala commented Dec 18, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 18, 2025
@Ganiredi
Copy link
Copy Markdown
Contributor Author

Ganiredi commented Dec 18, 2025

/retest

@Ganiredi Ganiredi force-pushed the v1.35.0 branch 3 times, most recently from e2ba828 to 93ff90d Compare December 18, 2025 14:39
kmala
kmala reviewed Dec 18, 2025
View reviewed changes
Comment thread Dockerfile Outdated
kmala
kmala reviewed Dec 18, 2025
View reviewed changes
Comment thread Dockerfile
Copy link
Copy Markdown
Member

@kmala kmala Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the gorunner image also

Copy link
Copy Markdown
Member

@kmala kmala Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need to udpate the cloudbuild.yaml and .ko file etc

@Ganiredi
Copy link
Copy Markdown
Contributor Author

Ganiredi commented Dec 18, 2025

/retest

kmala
kmala reviewed Dec 18, 2025
View reviewed changes
Comment thread Makefile Outdated
kmala
kmala reviewed Dec 18, 2025
View reviewed changes
Comment thread go.mod Outdated
@kmala
Copy link
Copy Markdown
Member

kmala commented Dec 18, 2025

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2025
@Ganiredi Ganiredi force-pushed the v1.35.0 branch 3 times, most recently from f8e58ef to e72825e Compare December 19, 2025 19:10
@Ganiredi
Copy link
Copy Markdown
Contributor Author

Ganiredi commented Dec 19, 2025

kubernetes/kops@0d49465b70dd8a1ca44b350b3906504d992e09a1:Seems kops changed this behavior

@kmala
Copy link
Copy Markdown
Member

kmala commented Dec 22, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@k8s-ci-robot k8s-ci-robot merged commit d1c7c02 into kubernetes:master Dec 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmala kmala kmala left review comments

@cheftako cheftako Awaiting requested review from cheftako

@mmerkes mmerkes Awaiting requested review from mmerkes

Assignees

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ganiredi @k8s-ci-robot @kmala