Ignore nodes outside configured region

[benturnkey]

What type of PR is this?
/kind feature

What this PR does / why we need it:

The AWS cloud provider now ignores nodes whose providerID points to a different AWS region than the controller's configured region when checking instance existence or shutdown state.

Which issue(s) this PR fixes:

Addresses #939 by preventing controllers from interfering with nodes it doesn't own.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The AWS cloud provider now ignores nodes whose `providerID` points to a different AWS region than the controller's configured region when checking instance existence or shutdown state.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: benturnkey / name: Ben Wilson (7058901)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Welcome @benturnkey!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @benturnkey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

What does 1abc-2def represent here?

[benturnkey]

Additional custom identifiers. We only ensure region and instance are valid for operation.

[JoelSpeed]

Are custom identifiers supported by the CCM/Kubelet? How do other parts of the CCM already handle the provider ID, is there existing logic that parses the provider ID that we could re-use?

[benturnkey]

Additional identifiers could be used by Fargate or Outpost.

https://github.com/kubernetes/cloud-provider-aws/blob/master/pkg/providers/v1/aws_test.go#L3675

[JoelSpeed]

If the instance ID is bare, will it ever have a region prefix? When/why would the instance ID be bare?

[benturnkey]

If the instance ID is bare, will it ever have a region prefix?
No, it was an attempt to coerce the bare instance into something parsable without erroring.

When/why would the instance ID be bare?
Just trying to cover any case.

[JoelSpeed]

If the instance ID isn't prefixed, and isn't prefixed aws://, I would expect we just ignore the node rather than trying to coerce anything no?

[benturnkey]

I mean, when you put it that way, yeah.

I'll push a change.

[JoelSpeed]

@benturnkey There are a lot of commits in this PR which don't look like they are relevant to the actual goal of the PR, what's going on with those other commits?

[benturnkey]

@benturnkey There are a lot of commits in this PR which don't look like they are relevant to the actual goal of the PR, what's going on with those other commits?

Yeah, sorry, I reused the branch for some other testing. Reverted 🙏