Skip to content

1.36.0 rc release#1382

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Ganiredi:1.36-k8s-deps
Apr 23, 2026
Merged

1.36.0 rc release#1382
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
Ganiredi:1.36-k8s-deps

Conversation

@Ganiredi
Copy link
Copy Markdown
Contributor

@Ganiredi Ganiredi commented Apr 15, 2026 •
edited
Loading

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Updates ccm with latest k8s dependencies

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 15, 2026
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

This issue is currently awaiting triage.

If cloud-provider-aws contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

Hi @Ganiredi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2026
kmala
kmala reviewed Apr 21, 2026
View reviewed changes
Comment thread Dockerfile Outdated
# kube-controller-manager, for example for 1.23.x:
# https://github.com/kubernetes/kubernetes/blob/release-1.24/build/common.sh#L94
ARG DISTROLESS_IMAGE=registry.k8s.io/build-image/go-runner:v2.4.0-go1.25.5-bookworm.0
ARG DISTROLESS_IMAGE=registry.k8s.io/build-image/go-runner:v2.4.0-go1.26.0-bookworm.0
Copy link
Copy Markdown
Member

@kmala kmala Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update to 1.26.2 ?

Comment thread Dockerfile Outdated
################################################################################
# This build arg allows the specification of a custom Golang image.
ARG GOLANG_IMAGE=golang:1.25.5
ARG GOLANG_IMAGE=golang:1.26.0
Copy link
Copy Markdown
Member

@kmala kmala Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update to 1.26.2

Comment thread cloudbuild.yaml Outdated
- .
# Build cloudbuild artifacts (for attestation)
- name: 'docker.io/library/golang:1.25.5-bookworm'
- name: 'docker.io/library/golang:1.26.0-bookworm'
Copy link
Copy Markdown
Member

@kmala kmala Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 1.26.2

Comment thread .ko.yaml Outdated
@@ -1 +1 @@
defaultBaseImage: registry.k8s.io/build-image/go-runner:v2.4.0-go1.25.5-bookworm.0
defaultBaseImage: registry.k8s.io/build-image/go-runner:v2.4.0-go1.26.0-bookworm.0
Copy link
Copy Markdown
Member

@kmala kmala Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to 1.26.2

@racheljpg racheljpg mentioned this pull request Apr 22, 2026
Closed
kmala
kmala reviewed Apr 22, 2026
View reviewed changes
Comment thread Makefile Outdated
LDFLAGS ?= -w -s -X k8s.io/component-base/version.gitVersion=$(VERSION) -X main.gitVersion=$(VERSION)

GOLANG_DIRECTIVE_VERSION ?= 1.25.0
GOLANG_DIRECTIVE_VERSION ?= 1.26.2
Copy link
Copy Markdown
Member

@kmala kmala Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave it as 1.26.0

Comment thread go.mod Outdated
module k8s.io/cloud-provider-aws

go 1.25.0
go 1.26.2
Copy link
Copy Markdown
Member

@kmala kmala Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this as 1.26.0

Comment thread tests/e2e/go.mod Outdated
module k8s.io/cloud-provider-aws/tests/e2e

go 1.25.0
go 1.26.2
Copy link
Copy Markdown
Member

@kmala kmala Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this as 1.26.0

@kmala
Copy link
Copy Markdown
Member

kmala commented Apr 22, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 22, 2026
@Ganiredi
Copy link
Copy Markdown
Contributor Author

Ganiredi commented Apr 22, 2026

/test pull-cloud-provider-aws-e2e-kubetest2-quick

@kmala
Copy link
Copy Markdown
Member

kmala commented Apr 23, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2026
@k8s-ci-robot k8s-ci-robot merged commit 3b7a391 into kubernetes:master Apr 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmala kmala kmala left review comments

@cheftako cheftako Awaiting requested review from cheftako

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@kmala kmala

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ganiredi @k8s-ci-robot @kmala