Skip to content

feat: Add ALPN policy annotation for NLB TLS listeners#1397

Open
alimx07 wants to merge 1 commit into
kubernetes:masterfrom
alimx07:feat/add-alpn-annotation
Open

feat: Add ALPN policy annotation for NLB TLS listeners#1397
alimx07 wants to merge 1 commit into
kubernetes:masterfrom
alimx07:feat/add-alpn-annotation

Conversation

@alimx07
Copy link
Copy Markdown

@alimx07 alimx07 commented May 4, 2026

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds service.beta.kubernetes.io/aws-load-balancer-alpn-policy annotation to configure the ALPN policy on NLB TLS listeners. Valid values are HTTP1Only, HTTP2Only, HTTP2Optional, HTTP2Preferred, and None. Applied only when aws-load-balancer-ssl-cert is also set. Removing the annotation from an existing service explicitly resets the listener to None.

Which issue(s) this PR fixes:
Fixes #1309

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add `service.beta.kubernetes.io/aws-load-balancer-alpn-policy` annotation to configure the ALPN policy on NLB TLS listeners. Valid values: `HTTP1Only`, `HTTP2Only`, `HTTP2Optional`, `HTTP2Preferred`, `None`. Requires `aws-load-balancer-ssl-cert` to be set.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 4, 2026
@k8s-ci-robot k8s-ci-robot requested review from cheftako and dims May 4, 2026 02:46
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bridgetkromhout for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @alimx07!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 4, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @alimx07. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 4, 2026
@alimx07
Copy link
Copy Markdown
Author

alimx07 commented May 4, 2026

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 4, 2026
@alimx07
Copy link
Copy Markdown
Author

alimx07 commented May 4, 2026

/cc @kmala

@k8s-ci-robot k8s-ci-robot requested a review from kmala May 4, 2026 09:52

SSLCertificateARN string
SSLPolicy string
ALPNPolicy string
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the listener supports multiple ALPN policies, we should also support multiple i think?

Copy link
Copy Markdown
Author

@alimx07 alimx07 May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kmala , While that sounds reasonable, the AWS SDK actually only allows one ALPN policy per listener as they state here. So I though of keeping it as single string for simplicity. Ofc, keeping it slice with one string will do the job also.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that its a list but only single value is supported.

@alimx07
Copy link
Copy Markdown
Author

alimx07 commented May 9, 2026

Hi @kmala, If you have time, could you look at this again. Thanks in advance!

@kmala
Copy link
Copy Markdown
Member

kmala commented May 9, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented May 9, 2026

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 9, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented May 12, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide annotation for ALPN profile on NLB

3 participants