feat: Add ALPN policy annotation for NLB TLS listeners#1397
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @alimx07! |
|
Hi @alimx07. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/kind feature |
|
/cc @kmala |
|
|
||
| SSLCertificateARN string | ||
| SSLPolicy string | ||
| ALPNPolicy string |
There was a problem hiding this comment.
Since the listener supports multiple ALPN policies, we should also support multiple i think?
There was a problem hiding this comment.
interesting that its a list but only single value is supported.
|
Hi @kmala, If you have time, could you look at this again. Thanks in advance! |
|
/ok-to-test |
|
/triage accepted |
|
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds
service.beta.kubernetes.io/aws-load-balancer-alpn-policyannotation to configure the ALPN policy on NLB TLS listeners. Valid values areHTTP1Only,HTTP2Only,HTTP2Optional,HTTP2Preferred, andNone. Applied only whenaws-load-balancer-ssl-certis also set. Removing the annotation from an existing service explicitly resets the listener toNone.Which issue(s) this PR fixes:
Fixes #1309
Special notes for your reviewer:
Does this PR introduce a user-facing change?: