Skip to content

KEP-4742: promote PodTopologyLabelAdmission to beta #5428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −5
Open

KEP-4742: promote PodTopologyLabelAdmission to beta #5428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions keps/sig-node/4742-node-topology-downward-api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ we aim to simplify access to this information for Pods via the Downward API.

### Goals

* Values from Node labels `topology.k8s.io/zone`, `topology.k8s.io/region` and `kubernetes.io/hostname` are made
* Values from Node labels `topology.kubernetes.io/zone`, `topology.kubernetes.io/region` and `kubernetes.io/hostname` are made
available via downward API
* Additional node labels can be made available via downward API using admission webhooks that mutate `pods/binding`.

Expand Down Expand Up @@ -225,7 +225,8 @@ E2E tests will also ensure behavior is exercised when the feature gate is enable

#### Beta

TODO after Alpha.
- Fix standard topology label used in PodTopologyLabels admission controller (topology.k8s.io -> topology.kubernetes.io)
- Unit, integration and e2e tests

#### GA

Expand Down Expand Up @@ -290,7 +291,9 @@ Tests will be added to ensure feature gate works as expected.

### Rollout, Upgrade and Rollback Planning

TODO for Beta.
Manual testing will be exercised to ensure that PodTopologyLabelsAdmission can be enabled and then disabled.
When disabled, existing Pods with topology labels will continue to run with those labels and new Pods will no longer
container topology labels.

###### How can a rollout or rollback fail? Can it impact already running workloads?

Expand Down Expand Up @@ -402,6 +405,7 @@ Revert feature gate and stop consuming downward API.
## Implementation History

- `v1.33`: initial KEP is accepeted and alpha implementation is complete
- `v1.34`: fix topology labels from topology.k8s.io to topology.kubernetes.io.

## Drawbacks

Expand Down
4 changes: 2 additions & 2 deletions keps/sig-node/4742-node-topology-downward-api/kep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ stage: alpha
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.33"
latest-milestone: "v1.34"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.33"
# beta: "v1.34"
beta: "v1.35"
# stable: "v1.35"

# The following PRR answers are required at alpha release
Expand Down