KEP 1645: add ServiceImport conditions #5439
Open
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
kind/kep
k8s-ci-robot
added
sig/multicluster
|
I would bring this in the next sig meeting but if you have any comment and/or want to review this prior to the meeting feel free! |
MrFreezeex
force-pushed
the
svcimport-conditions
branch
from
7def6e0 to
e68fa5b
Compare
MrFreezeex
changed the title
MrFreezeex
force-pushed
the
svcimport-conditions
branch
from
e68fa5b to
1c3b48e
Compare
tpantelis
reviewed
Jun 27, 2025
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
MrFreezeex
force-pushed
the
svcimport-conditions
branch
from
1c3b48e to
4b5054a
Compare
|
Agreed this makes sense as a general-purpose mechanism for surfacing issues which can not be discovered at export time. /lgtm |
k8s-ci-robot
added
the
lgtm
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we had the conditions fields only on ServiceExport, trying to implement dual stack on Cilium and Submariner highlighted that there could be some "import time" errors as well. For instance, having an IPv6 only service and trying to import in IPv4 only clusters which in both Cilium and Submariner raise some issue that we would want to report to users via the ServiceImport conditions.
This is not specifically tied to IP protocol/families issues but supposed to be a general thing for implementations to report any errors and status occurring during import time.