Skip to content

Addon nvidia-device-plugin: Update nvidia/k8s-device-plugin image from v0.17.0 to v0.17.1 #20534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

minikube-bot
Copy link
Collaborator

The k8s-device-plugin project released a new k8s-device-plugin image

This PR was auto-generated by make update-nvidia-device-plugin-version using update-nvidia-device-plugin-version.yml CI Workflow.

@minikube-bot minikube-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2025
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from 02bb195 to 3766b6c Compare March 24, 2025 10:01
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from 3766b6c to 63f3d3f Compare March 31, 2025 10:01
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from 63f3d3f to d659212 Compare April 7, 2025 10:01
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from d659212 to ca4340f Compare April 14, 2025 10:01
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Windows (2 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Windows (2 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) Unknown

Besides the following environments also have failed tests:

  • Docker_Linux_containerd_arm64: 1 failed (gopogh)

  • KVM_Linux_crio: 10 failed (gopogh)

  • Docker_Linux_crio: 12 failed (gopogh)

  • Docker_Cloud_Shell: 3 failed (gopogh)

  • Docker_Linux_crio_arm64: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@minikube-bot minikube-bot force-pushed the auto_bump_nvidia_device_plugin_version branch from ca4340f to cefb857 Compare April 21, 2025 10:01
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20534) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 49.1s               |
| enable ingress | 18.2s    | 16.2s               |
+----------------+----------+---------------------+

Times for minikube (PR 20534) start: 49.6s 52.3s 47.4s 48.1s 48.1s
Times for minikube start: 50.8s 47.3s 48.6s 51.0s 50.3s

Times for minikube ingress: 27.0s 15.0s 15.0s 18.5s 15.5s
Times for minikube (PR 20534) ingress: 14.5s 15.0s 18.0s 18.5s 15.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20534) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.5s               |
| enable ingress | 12.8s    | 12.8s               |
+----------------+----------+---------------------+

Times for minikube start: 21.6s 21.5s 24.0s 22.4s 21.5s
Times for minikube (PR 20534) start: 21.5s 20.7s 22.1s 22.0s 21.2s

Times for minikube ingress: 13.3s 12.3s 12.3s 12.8s 13.4s
Times for minikube (PR 20534) ingress: 13.8s 12.3s 13.3s 12.4s 12.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20534) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 22.1s               |
| enable ingress | 38.8s    | 36.8s               |
+----------------+----------+---------------------+

Times for minikube start: 20.9s 20.7s 22.1s 21.3s 20.4s
Times for minikube (PR 20534) start: 23.3s 22.8s 21.2s 20.5s 22.8s

Times for minikube ingress: 38.8s 38.8s 38.9s 38.8s 38.8s
Times for minikube (PR 20534) ingress: 38.8s 39.8s 38.8s 38.8s 27.8s

@medyagh
Copy link
Member

medyagh commented Apr 24, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2025
@medyagh
Copy link
Member

medyagh commented Apr 24, 2025

/lgtm

@medyagh medyagh merged commit 682dd5b into kubernetes:master Apr 24, 2025
28 of 40 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, minikube-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants