Skip to content

add artifact precheck#2122

Merged
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature
Feb 13, 2024
Merged

add artifact precheck#2122
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. add artifact precheck
  2. add default hostname (localhost) to represent local mechine if inventory not set.
  3. fix local file watcher invalid

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

add artifact precheck
add default hostname (localhost) to represent local mechine if inventory not set.
fix local file watcher invalid

Additional documentation, usage docs, etc.:


Signed-off-by: joyceliu <joyceliu@yunify.com>
feat: add default hostname (localhost) to represent local mechine if inventory not set.

Signed-off-by: joyceliu <joyceliu@yunify.com>
@ks-ci-bot ks-ci-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2024
@redscholar redscholar changed the title Feature add artifact precheck Feb 7, 2024
@ks-ci-bot ks-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 7, 2024
@pixiake
Copy link
Copy Markdown
Collaborator

pixiake commented Feb 13, 2024

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@ks-ci-bot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 81038c91550e51f10a45f3fc265c7e944e07ae41

@ks-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImitationImmortal, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@ks-ci-bot ks-ci-bot merged commit ca663b2 into kubesphere:feature-gitops Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants