Skip to content

fix: graceful delete runtime dir.#2393

Merged
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature
Sep 6, 2024
Merged

fix: graceful delete runtime dir.#2393
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

@redscholar redscholar commented Sep 6, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:

@redscholar
fix: graceful delete runtime dir.
4dbd3f4 
Signed-off-by: joyceliu <joyceliu@yunify.com>
@kubesphere-prow kubesphere-prow bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Sep 6, 2024
@kubesphere-prow
Copy link
Copy Markdown

kubesphere-prow bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2024
@redscholar redscholar marked this pull request as draft September 6, 2024 03:14
@kubesphere-prow kubesphere-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@redscholar
fix: graceful delete runtime dir.
ad8bc16 
Signed-off-by: joyceliu <joyceliu@yunify.com>
@kubesphere-prow
Copy link
Copy Markdown

kubesphere-prow bot commented Sep 6, 2024

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@redscholar redscholar marked this pull request as ready for review September 6, 2024 03:16
@kubesphere-prow kubesphere-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2024
@liangzai006
Copy link
Copy Markdown
Contributor

liangzai006 commented Sep 6, 2024

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
@kubesphere-prow
Copy link
Copy Markdown

kubesphere-prow bot commented Sep 6, 2024

LGTM label has been added.

DetailsGit tree hash: 884f9bc926e9e88e0d281230d3dc450a1d9857ae

@ks-ci-bot ks-ci-bot merged commit 48831c7 into kubesphere:feature-gitops Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@liangzai006 liangzai006

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@redscholar @liangzai006 @ks-ci-bot