Skip to content

feat: Parse YAML parameters sequentially.#2555

Merged
pixiake merged 1 commit intokubesphere:feature-gitopsfrom
redscholar:feature
May 7, 2025
Merged

feat: Parse YAML parameters sequentially.#2555
pixiake merged 1 commit intokubesphere:feature-gitopsfrom
redscholar:feature

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

@redscholar redscholar commented May 6, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Variables are parsed and stored on a per-host basis during playbook execution.
The parsing priority when using YAML v3 to evaluate variables is as follows:

- name: playbook
   host:
    - localhost
   vars_files:
    - file1
    - file2
   vars:
     a: b

Priority Order (highest to lowest):

  1. vars (e.g., a: b)
  2. file1 (first in list)
  3. file2 (last in list)

Note: If a later-defined variable conflicts with an earlier one, the later value overrides the earlier definition.

Which issue(s) this PR fixes:

Fixes # #2496

Special notes for reviewers:

Does this PR introduced a user-facing change?

Parse YAML parameters sequentially.

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note kind/feature Categorizes issue or PR as related to a new feature. labels May 6, 2025
@kubesphere-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@redscholar redscholar added do-not-merge/hold and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2025
@kubesphere-prow kubesphere-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 6, 2025
@kubesphere-prow kubesphere-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@redscholar redscholar force-pushed the feature branch 2 times, most recently from f51b7a9 to 4be4783 Compare May 7, 2025 06:17
Signed-off-by: joyceliu <joyceliu@yunify.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pixiake pixiake merged commit 9502ac5 into kubesphere:feature-gitops May 7, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants