Skip to content

fix: change failed_when execute time#2586

Merged
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature
May 22, 2025
Merged

fix: change failed_when execute time#2586
ks-ci-bot merged 2 commits intokubesphere:feature-gitopsfrom
redscholar:feature

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

@redscholar redscholar commented May 22, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

  1. change failed_when execute time
  2. rename package pkg/util -> pkg/controllers/util

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

change failed_when execute time

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note kind/bug Categorizes issue or PR as related to a bug. labels May 22, 2025
@kubesphere-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 22, 2025
Signed-off-by: joyceliu <joyceliu@yunify.com>
@kubesphere-prow
Copy link
Copy Markdown

This PR has multiple commits, and the default merge method is: squash.
You can request commits to be merged using the label: tide/merge-method-merge

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: joyceliu <joyceliu@yunify.com>
@sonarqubecloud
Copy link
Copy Markdown

@pixiake
Copy link
Copy Markdown
Collaborator

pixiake commented May 22, 2025

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@kubesphere-prow
Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 2e16a515563b69f202fc87dbfc56a98b796bac48

@ks-ci-bot ks-ci-bot merged commit d979c92 into kubesphere:feature-gitops May 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants