Skip to content

fix: add Delete arp by kube-vip when uninstall/kubernetes#2596

Merged
kubesphere-prow[bot] merged 1 commit intokubesphere:feature-gitopsfrom
redscholar:feature
May 28, 2025
Merged

fix: add Delete arp by kube-vip when uninstall/kubernetes#2596
kubesphere-prow[bot] merged 1 commit intokubesphere:feature-gitopsfrom
redscholar:feature

Conversation

@redscholar
Copy link
Copy Markdown
Contributor

@redscholar redscholar commented May 28, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

add Delete arp by kube-vip when uninstall/kubernetes
if set kubernetes.control_plane_endpoint.type is kube_vip should delete the arp address (same as capkk)

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

none

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels May 28, 2025
@kubesphere-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: redscholar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubesphere-prow kubesphere-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2025
Signed-off-by: joyceliu <joyceliu@yunify.com>
@sonarqubecloud
Copy link
Copy Markdown

@pixiake
Copy link
Copy Markdown
Collaborator

pixiake commented May 28, 2025

/lgtm

@kubesphere-prow kubesphere-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@kubesphere-prow
Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 40261635dd12c13c48eb867a5d192f017bbd8f20

@kubesphere-prow kubesphere-prow bot merged commit 71265ad into kubesphere:feature-gitops May 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants