bugfix: fix create config kube version key

[zuoxuesong-worker]

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix create config kube version key

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

 fix create config kube version key

Does this PR introduced a user-facing change?

fix create config kube version key

Additional documentation, usage docs, etc.:

 fix create config kube version key

[kubesphere-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zuoxuesong-worker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zuoxuesong-worker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @zuoxuesong-worker, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in how the Kubernetes version key is handled during the creation of configuration files. The change ensures that the kube_version parameter is correctly nested within a kubernetes object when passed to the configuration template, resolving an issue where the key might have been incorrectly interpreted or missing in the generated configuration.

Highlights

• Configuration Template Data Structure: Modified the data structure passed to the t.Execute function when generating the configuration file. It now uses a nested map[string]any{"kubernetes": map[string]any{"kube_version": kubeVersion}} instead of a flat map[string]string{"kube_version": kubeVersion}. This ensures the kube_version is correctly nested under a kubernetes key in the template context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an issue with the kube_version key when generating a default configuration from a template. The change correctly identifies that some templates expect a nested structure (kubernetes.kube_version), but the implementation breaks compatibility with templates that expect a top-level kube_version key. My review includes a critical feedback with a code suggestion to support both structures, ensuring that all default configuration templates can be rendered correctly.

[gemini-code-assist]

The current change fixes an issue where {{ .kubernetes.kube_version }} would not render correctly in the config templates. However, it removes the top-level kube_version key from the data passed to the template.

Many of the config templates (e.g., builtin/core/defaults/config/v1.33.yaml) and parts of other templates (e.g., line 9 in v1.23.yaml through v1.32.yaml and v1.34.yaml) still use {{ .kube_version }}. This change will cause template execution to fail for those cases.

To fix this without breaking existing templates, you should provide both the top-level kube_version and the nested kubernetes.kube_version in the data map. This ensures both syntaxes are supported.

Suggested change

	if err := t.Execute(data, map[string]any{"kubernetes": map[string]any{"kube_version": kubeVersion}}); err != nil {
	if err := t.Execute(data, map[string]any{"kube_version": kubeVersion, "kubernetes": map[string]any{"kube_version": kubeVersion}}); err != nil {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[redscholar]

/lgtm

[kubesphere-prow]

LGTM label has been added.

Details

Git tree hash: db7a76d45391c11a2fe823d4135f0612c1241053