Skip to content

fix(meshfaultinjection): deprecate spec.from field #16102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Automaat merged 2 commits into from
Apr 3, 2026
Merged

fix(meshfaultinjection): deprecate spec.from field #16102

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
692575f
fix(meshfaultinjection): deprecate spec.from field
Automaat Apr 2, 2026
d1415e9
fix(meshfaultinjection): address review comments
Automaat Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions pkg/plugins/policies/meshfaultinjection/api/v1alpha1/deprecated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
package v1alpha1

import (
"github.com/kumahq/kuma/v2/api/common/v1alpha1"
"github.com/kumahq/kuma/v2/pkg/plugins/policies/core/jsonpatch/validators"
"github.com/kumahq/kuma/v2/pkg/util/pointer"
)

func (t *MeshFaultInjectionResource) Deprecations() []string {
deprecations := validators.TopLevelTargetRefDeprecations(t.Spec.TargetRef)
for _, f := range pointer.Deref(t.Spec.From) {
if f.GetTargetRef().Kind == v1alpha1.MeshService {
deprecations = append(deprecations, "MeshService value for 'from[].targetRef.kind' is deprecated, use MeshSubset with 'kuma.io/service' instead")
}
var deprecations []string
if len(pointer.Deref(t.Spec.From)) > 0 {
deprecations = append(deprecations, "'from' field is deprecated, use 'rules' with SPIFFE-based 'matches' instead")
}
return deprecations
return append(deprecations, validators.TopLevelTargetRefDeprecations(t.Spec.TargetRef)...)
}
Loading