Skip to content

mcp perf#6697

Merged
c121914yu merged 2 commits intomainfrom
v4.14.10-dev
Apr 1, 2026
Merged

mcp perf#6697
c121914yu merged 2 commits intomainfrom
v4.14.10-dev

Conversation

@c121914yu
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings April 1, 2026 09:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves MCP client connection handling in the service layer, aiming to reduce connection issues/noise while preferring the Streamable HTTP transport with an SSE fallback.

Changes:

  • Forces a Client.close() before establishing a new MCP connection attempt.
  • Prefers StreamableHTTPClientTransport, falls back to SSEClientTransport on failure.
  • Moves onerror/onclose handlers into doConnect() and adds a selective error ignore rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 50.51% 20046 / 39683
🔵 Statements 50.51% 20046 / 39683
🔵 Functions 54.3% 631 / 1162
🔵 Branches 87.76% 3729 / 4249
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/service/core/app/mcp.ts 87.17% 86.48% 72.72% 87.17% 33-34, 65-83, 91-94, 96-97
Generated in workflow #276 for commit 19e3f92 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Build Successful - Preview code-sandbox Image for this PR:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:code-sandbox_19e3f9296d3bed5c50e404559ef4578e4c607b7c

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Build Successful - Preview fastgpt Image for this PR:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fastgpt_19e3f9296d3bed5c50e404559ef4578e4c607b7c

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

Build Successful - Preview mcp_server Image for this PR:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:mcp_server_19e3f9296d3bed5c50e404559ef4578e4c607b7c

@c121914yu c121914yu merged commit 8e248d7 into main Apr 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants